sdist licensing follow ups #2843
Conversation
| @@ -37,6 +37,7 @@ const version = pkg.version.replace(/-(rc|alpha|beta)\.\d+/, (x) => | |||
| ); | |||
|
|
|||
| fs.mkdirSync(`./perspective_python-${version}.data`, { recursive: true }); | |||
| fs.copyFileSync("../../LICENSE.md", "./LICENSE.md"); | |||
There was a problem hiding this comment.
it turns out maturin develop needs this file around now that it's specified in pyproject.toml as {license { file = "LICENSE.md" }}, so I moved it out of the sdist branch so it always runs.
| cmake_args | ||
| ); | ||
| for arg in Shlex::new(&cmake_args) { | ||
| dst.configure_arg(arg); | ||
| } | ||
| } | ||
|
|
||
| println!("cargo:warning=MESSAGE Building cmake {}", profile); | ||
| println!("cargo:warning=Building cmake {}", profile); |
There was a problem hiding this comment.
MESSAGE is not needed in these warnings, I think we misunderstood the docs. See this CI run: https://github.com/tomjakubowski/perspective-oneoff-tests/actions/runs/11752078774/job/32743108312
Signed-off-by: Tom Jakubowski <tom@prospective.dev>
|
Not ready yet, need to update CI so that the metadata is copied for perspective-python (and then pulled down for the sdist build). I'll find an hour to do that this weekend
is not the same as |
Signed-off-by: Tom Jakubowski <tom@prospective.dev>
This adds LICENSE.md from perspective to the sdist, and uses
cargo-bundle-licensesto bundle perspective-python's dependency licenses into LICENSE_THIRDPARTY_cargo.yml, which is also added to the sdist.When Maturin builds a wheel, it searches the source for files named
LICENSE*(among others) and includes them in dist-info. C++ license packaging can use this same framework: we'll generate a file in the perspective-python source tree which aggregates licenses from arrow and other bundled C++ dependencies.Adds a basic test of the license packaging to the sdist test. Note that this doesn't test the wheels we distribute, which takes a different build path in CI.