Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdist licensing follow ups #2843

Merged
merged 2 commits into from
Nov 13, 2024
Merged

sdist licensing follow ups #2843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
269fbe6
sdist: include LICENSE.md file
tomjakubowski Nov 8, 2024
053abcd
sdist: include bundled Cargo dependency licenses
tomjakubowski Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ jobs:
rust/perspective-client/docs/
rust/perspective-js/src/ts/
rust/perspective-viewer/src/ts/
rust/perspective-python/LICENSE_THIRDPARTY_cargo.yml

# ,-,---. . . ,-_/ .---. .
# '|___/ . . . | ,-| ' | ,-. . , ,-. \___ ,-. ,-. . ,-. |-
Expand Down Expand Up @@ -485,6 +486,11 @@ jobs:
name: perspective-js-dist
path: .

- uses: actions/download-artifact@v4
with:
name: perspective-metadata
path: rust/

- uses: actions/download-artifact@v4
with:
name: perspective-python-dist-${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.python-version }}
Expand Down Expand Up @@ -707,6 +713,13 @@ jobs:
shell: bash
run: python -m pip install -vv ./perspective*.tar.gz

- name: Verify licenses are installed
shell: bash
run: |
pip show -f perspective-python > wheel_installed_files.txt
grep licenses/LICENSE.md wheel_installed_files.txt
grep licenses/LICENSE_THIRDPARTY_cargo.yml wheel_installed_files.txt

- name: Verify labextension
shell: bash
run: |
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,8 @@ rust/perspective-server/cmake
.pyodide-*/
rust/perspective-python/*.data
rust/perspective-python/PKG-INFO
# rust/perspective-python/perspective.data/data/share/jupyter/labextensions/@finos/perspective-jupyterlab/package.json
rust/perspective-python/LICENSE.md
rust/perspective-python/LICENSE_*
rust/perspective-viewer/docs/exprtk.md
rust/perspective-server/docs/lib_gen.md
rust/perspective-client/docs/expression_gen.md
Loading
Loading