Implemented eventarc event publishing API #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egilmorez
reviewed
Mar 29, 2022
| @@ -0,0 +1,25 @@ | |||
|
|
|||
| /** | |||
| * A CloudEvent version. | |||
There was a problem hiding this comment.
Should this be backticked just like Eventarc in firebase-namespace.ts?
Or is CloudEvent just a camel-cased product name?
There was a problem hiding this comment.
yeah, I think CloudEvent here is, not a product name, but the spec... don't think it needs the backticks.
There was a problem hiding this comment.
Thank you @pavelgj !
Didn't dive into tests, yet. Added a few comments, mostly style changes and suggestions.
lahirumaramba
requested changes
Apr 7, 2022
There was a problem hiding this comment.
Thank you for addressing the PR feedback @pavelgj !
Looks pretty good! Left a few more comments.
lahirumaramba
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Thank you @pavelgj. LGTM!
Do we plan to add any integration tests later?
|
Yes, I will work on the integration tests. |
pavelgj
added a commit
that referenced
this pull request
Apr 14, 2022
pavelgj
added a commit
that referenced
this pull request
Apr 25, 2022
pavelgj
added a commit
that referenced
this pull request
May 4, 2022
pavelgj
added a commit
that referenced
this pull request
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go/gnqghm1gqpp6