Implemented eventarc event publishing API (#1617) #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egilmorez
reviewed
Apr 14, 2022
|
Thanks Pavel! Could you take a pass through for the two global nits? This was the "ask:" Wherever possible, use present tense is instead of "will" or "will be." Also, commas after phrases like "if not provided" help the flow. There are several more instances of both to look at. |
|
@egilmorez made another global pass as per your suggestion. PTAL. |
kevinthecheung
approved these changes
Apr 14, 2022
egilmorez
approved these changes
Apr 25, 2022
lahirumaramba
approved these changes
May 4, 2022
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
|
Rebased onto master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.