Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backporting documentation changes #550

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Backporting documentation changes #550

merged 1 commit into from
Jun 21, 2019

Conversation

rsgowman
Copy link
Member

As suggested by Rachel.

@googlebot googlebot added the cla: yes Override cla label Jun 20, 2019
earnestsaunders
earnestsaunders approved these changes Jun 20, 2019
View reviewed changes
Copy link

@earnestsaunders earnestsaunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

@rsgowman: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed 55ecf8c link /test check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

thebrianchen
thebrianchen approved these changes Jun 21, 2019
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsgowman rsgowman merged commit 33706a9 into master Jun 21, 2019
@rsgowman rsgowman deleted the rsgowman/doc_backport branch June 21, 2019 16:23
@thebrianchen thebrianchen mentioned this pull request Jun 24, 2019
Merged
schmidt-sebastian pushed a commit that referenced this pull request Jun 25, 2019
@rsgowman @schmidt-sebastian
Backporting documentation changes (#550)
860c71e
schmidt-sebastian pushed a commit that referenced this pull request Jun 27, 2019
@rsgowman @schmidt-sebastian
Backporting documentation changes (#550)
f2e25f0
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

@earnestsaunders earnestsaunders earnestsaunders approved these changes

Assignees

@thebrianchen thebrianchen

Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rsgowman @google-oss-bot @thebrianchen @earnestsaunders @googlebot