Backport updates from Android (multiple changes) #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 24, 2019 13:19
…tId, backport documentation updates from Android
thebrianchen
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
mikelehen
suggested changes
Jun 25, 2019
mikelehen
approved these changes
Jun 25, 2019
|
@mikelehen I just realized that the current implementation of This means that Gil's refactor of filter PR needs to go in first, or else I'll be doing the logic twice. I'll submit this PR for now, and back-back-backport(?) the integration test once the Android refactor of Filter is done to include |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting changes from Android IN queries:
nullandNaNand reorganize tests to match Android SDKclearPersistence()to include Rachel's editsThis change introduces
KeyFieldInFilter, which stacks on top of @wilhuff's refactor (#1894). This will be ported to Android when he refactors the Android client.TODO: After this change goes in, I will update the error messages inside
parseDocumentIdValue()to match the Android SDK, since those error messages are more generally applicable to both IN queries and KeyFieldFilter queries.