Refactor Filters #1894
Merged
Refactor Filters #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to validate arguments once rather than per-document.
mikelehen
suggested changes
Jun 20, 2019
| @@ -1283,7 +1284,7 @@ export class JsonProtoSerializer { | |||
|
|
|||
| // visible for testing | |||
| toRelationFilter(filter: Filter): api.Filter { | |||
There was a problem hiding this comment.
toRelationFilter => toFieldFilter? And I guess this is preexisting weirdness but it really seems like the instanceof check should go in the caller and the filter parameter here should be FieldFilter, not Filter
There was a problem hiding this comment.
After removing NanFilter and NullFilter this becomes toUnaryOrFieldFilter because it now has to handle the difference between proto UnaryFilter and FieldFilter`.
|
BOOM! |
var-const
added a commit
that referenced
this pull request
Jun 25, 2019
#1894 introduced a regression that made persisted queries deserialize incorrectly. Fix the regression and add tests. The root cause is that the refactoring introduced a type hierarchy of classes derived from `FieldFilter`, but serializer always deserializes persisted filters to the base class `FieldFilter`, never to the derived types. This would have affected array-contains queries, in queries, and key field queries. Fixes #1904.
wilhuff
added a commit
to firebase/firebase-ios-sdk
that referenced
this pull request
Jul 15, 2019
wilhuff
added a commit
to firebase/firebase-ios-sdk
that referenced
this pull request
Jul 20, 2019
* Rename relation_filter.{h,cc} to field_filter.{h,cc}
* Rename RelationFilter to FieldFilter
* Move Filter::Create to FieldFilter
* Port api::Query::ValidateNewFilter
* Add ArrayContainsFilter
* Add KeyFieldFilter
* Make FieldFilter constructor protected
* Port FieldFilter refactor from the JS SDK
firebase/firebase-js-sdk#1894
* Add spec test from firebase/firebase-js-sdk#1913
* Accept array-contains as a synonym for array_contains
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bunch of related changes:
Each commit describes what it does individually.
cc @thebrianchen