Implement heartbeat controller #5723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3125e64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Feiyang1
reviewed
Nov 11, 2021
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (193,683 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
hsubox76
changed the title
Feiyang1
reviewed
Nov 30, 2021
packages/util/src/indexeddb.ts
Outdated
| reject((event.target as IDBRequest).error?.message); | ||
| }; | ||
|
|
||
| request.onupgradeneeded = event => { |
There was a problem hiding this comment.
You'd want this callback to be provided by the users of this utility class because the upgrade logic varies from use case to use case, and thus can't be generalized.
There was a problem hiding this comment.
Removed in favor of using idb.
packages/util/src/indexeddb.ts
Outdated
| * limitations under the License. | ||
| */ | ||
|
|
||
| export class IndexedDbDatabaseService { |
There was a problem hiding this comment.
It might be worth considering using the idb library which is tiny and provides the convenient APIs instead of rolling our own solution.
packages/app/src/types.ts
Outdated
| */ | ||
| heartbeatsCachePromise: Promise<HeartbeatsByUserAgent[]>; | ||
|
|
||
| /** |
There was a problem hiding this comment.
The comments are still useful.
There was a problem hiding this comment.
I put the comments on the class itself, do they need to be in both places?
There was a problem hiding this comment.
I think so. The consumer of the component will only look at the interface definition.
allspain
approved these changes
Dec 7, 2021
| await heartbeatService.triggerHeartbeat(); | ||
| expect(heartbeatService._heartbeatsCache?.length).to.equal(1); | ||
| const heartbeat1 = heartbeatService._heartbeatsCache?.[0]; | ||
| expect(heartbeat1?.userAgent).to.equal('vs1/1.2.3 vs2/2.3.4'); |
There was a problem hiding this comment.
For hardcoded strings we expect to match do we typically enter than as raw compares rather than define them as constants at the top of the file?
This isn't a neccesary change, the ROI might be low but it would reduce typo mistakes
packages/app/src/heartbeatService.ts
Outdated
| const monthString = month < 10 ? '0' + month : month.toString(); | ||
| const date = today.getUTCDate(); | ||
| const dayString = date < 10 ? '0' + date : date.toString(); | ||
| return `${yearString}-${monthString}-${dayString}`; |
There was a problem hiding this comment.
If you want to get rid of the custom logic here you could just do:
today.toISOString().substring(0,10)
allspain
approved these changes
Dec 10, 2021
This was referenced Feb 2, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement heartbeat controller.
Design doc (internal): go/firebasejssdk-heartbeat