Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Check heartbeat implementation #5967

Merged
merged 6 commits into from
Mar 15, 2022
Merged

App Check heartbeat implementation #5967

merged 6 commits into from
Mar 15, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Feb 2, 2022

Replace sending v1 platform logging header with sending new heartbeats header.

Will point at master and add changeset after heartbeat controller PR is merged: #5723

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 4663667

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/app-check Patch
@firebase/app-check-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Base automatically changed from ch-heartbeat to master February 24, 2022 18:34
zwu52 and others added 3 commits February 24, 2022 16:59
@zwu52 @hsubox76
parent 1588990
85eed92 
author Kai Wu <zwu52@users.noreply.github.com> 1645732197 -0800
committer Christina Holland <hsubox@gmail.com> 1645750725 -0800

Add Changeset for pull/5762 (#6030)

* Create pretty-mayflies-worry.md

* Update pretty-mayflies-worry.md

Move based indexedDB operations to util

add tests

Fix year

use idb

clean up

Add comments to HeartbeatService interface methods

Cache heartbeats one per date (#5945)
@hsubox76
App Check heartbeat implementation
71075a5
@hsubox76
add changeset, fix test
8f4b9cf
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 25, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app-check

    TypeBase (2b98b28)Merge (6d7d9a7)Diff
    browser25.1 kB25.2 kB+82 B (+0.3%)
    esm529.7 kB29.8 kB+148 B (+0.5%)
    main30.9 kB31.0 kB+148 B (+0.5%)
    module25.1 kB25.2 kB+82 B (+0.3%)

  • @firebase/firestore

    TypeBase (2b98b28)Merge (6d7d9a7)Diff
    browser251 kB248 kB-2.31 kB (-0.9%)
    esm5311 kB309 kB-2.21 kB (-0.7%)
    main500 kB498 kB-2.65 kB (-0.5%)
    module251 kB248 kB-2.31 kB (-0.9%)
    react-native251 kB249 kB-2.31 kB (-0.9%)

  • bundle

    TypeBase (2b98b28)Merge (6d7d9a7)Diff
    app-check (CustomProvider)35.7 kB35.7 kB+19 B (+0.1%)
    app-check (ReCaptchaEnterpriseProvider)37.9 kB37.9 kB+17 B (+0.0%)
    app-check (ReCaptchaV3Provider)37.8 kB37.9 kB+17 B (+0.0%)
    firestore (Persistence)263 kB261 kB-2.31 kB (-0.9%)
    firestore (Query Cursors)203 kB203 kB+224 B (+0.1%)
    firestore (Query)204 kB204 kB+224 B (+0.1%)
    firestore (Read data once)193 kB193 kB+224 B (+0.1%)
    firestore (Realtime updates)195 kB195 kB+224 B (+0.1%)
    firestore (Transaction)177 kB178 kB+224 B (+0.1%)
    firestore (Write data)177 kB177 kB+224 B (+0.1%)

  • firebase

    TypeBase (2b98b28)Merge (6d7d9a7)Diff
    firebase-app-check-compat.js22.7 kB22.7 kB+6 B (+0.0%)
    firebase-app-check.js89.9 kB90.0 kB+125 B (+0.1%)
    firebase-compat.js779 kB777 kB-2.33 kB (-0.3%)
    firebase-firestore-compat.js302 kB300 kB-2.33 kB (-0.8%)
    firebase-firestore.js836 kB818 kB-18.0 kB (-2.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FtNVefomWR.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 25, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (516,087 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/L6jGEY4cBf.html

allspain
allspain approved these changes Feb 25, 2022
View reviewed changes
Copy link

@allspain allspain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left minor feedback

packages/app-check/src/client.ts Show resolved Hide resolved
@allspain allspain assigned hsubox76 and unassigned allspain Feb 25, 2022
@hsubox76 hsubox76 merged commit a7f4a2e into master Mar 15, 2022
@hsubox76 hsubox76 deleted the ch-hb-appcheck branch March 15, 2022 18:42
@google-oss-bot google-oss-bot mentioned this pull request Mar 16, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevinthecheung kevinthecheung kevinthecheung approved these changes

@allspain allspain allspain approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hsubox76 @google-oss-bot @allspain @kevinthecheung @zwu52