-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: set exists:false precondition for deleted docs #6323
Conversation
|
Changeset File Check
|
Size Report 1Affected Products
Test Logs |
well... that didn't go as i expected heh |
Size Analysis Report 1Affected Products
Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to miss this. Have one suggestion, thanks!
@@ -142,12 +142,18 @@ export class Transaction { | |||
|
|||
/** | |||
* Returns the version of this document when it was read in this transaction, | |||
* as a precondition, or no precondition if it was not read. | |||
* as a precondition, or an existence precondition if the document did not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kind of list would normally only have one "or,"
so we'd have:
". . . as a precondition, an existence precondition if the document did not exist, or . . . ."
closing this in favor of #6550 |
No description provided.