Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: set exists:false precondition for deleted docs #6323

Closed
wants to merge 2 commits into from

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Jun 1, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2022

⚠️ No Changeset found

Latest commit: e3a55c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 1, 2022

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (9fddd5c)Merge (8bba1cf)Diff
    browser257 kB257 kB+34 B (+0.0%)
    esm5319 kB319 kB+34 B (+0.0%)
    main515 kB515 kB+83 B (+0.0%)
    module257 kB257 kB+34 B (+0.0%)
    react-native257 kB258 kB+34 B (+0.0%)
  • @firebase/firestore-lite

    TypeBase (9fddd5c)Merge (8bba1cf)Diff
    browser80.5 kB80.5 kB+34 B (+0.0%)
    esm596.2 kB96.2 kB+34 B (+0.0%)
    main135 kB135 kB+83 B (+0.1%)
    module80.5 kB80.5 kB+34 B (+0.0%)
    react-native80.7 kB80.7 kB+34 B (+0.0%)
  • bundle

    TypeBase (9fddd5c)Merge (8bba1cf)Diff
    firestore (Transaction)181 kB181 kB+34 B (+0.0%)
    firestore-lite (Transaction)80.0 kB80.0 kB+34 B (+0.0%)
  • firebase

    TypeBase (9fddd5c)Merge (8bba1cf)Diff
    firebase-compat.js787 kB787 kB+36 B (+0.0%)
    firebase-firestore-compat.js309 kB309 kB+36 B (+0.0%)
    firebase-firestore-lite.js267 kB267 kB+105 B (+0.0%)
    firebase-firestore.js837 kB837 kB+105 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nhORCOXQhu.html

@ehsannas
Copy link
Contributor Author

ehsannas commented Jun 1, 2022

well... that didn't go as i expected heh

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 1, 2022

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • runTransaction

      Size

      TypeBase (9fddd5c)Merge (8bba1cf)Diff
      size113 kB113 kB+33 B (+0.0%)
      size-with-ext-deps174 kB174 kB+34 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HEIaXaU37a.html

@google-oss-bot google-oss-bot added the doc-changes PRs that affect docs label Jun 1, 2022
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to miss this. Have one suggestion, thanks!

@@ -142,12 +142,18 @@ export class Transaction {

/**
* Returns the version of this document when it was read in this transaction,
* as a precondition, or no precondition if it was not read.
* as a precondition, or an existence precondition if the document did not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of list would normally only have one "or,"
so we'd have:

". . . as a precondition, an existence precondition if the document did not exist, or . . . ."

@ehsannas
Copy link
Contributor Author

closing this in favor of #6550

@ehsannas ehsannas closed this Aug 25, 2022
@firebase firebase locked and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
doc-changes PRs that affect docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants