Firestore: Fix FAILED_PRECONDITION when writing to a deleted document in a transaction

[dconeybe]

Note: This fix needs to be ported to android and ios.

Fixes #5871

[changeset-bot]

🦋 Changeset detected

Latest commit: 2b9f7d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/firestore	Patch
firebase	Patch
@firebase/firestore-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[google-oss-bot]

Size Report ¹

Affected Products

• @firebase/firestore

  Type	Base (0361bf3)	Merge (1eeecde)	Diff
  browser	264 kB	264 kB	+34 B (+0.0%)
  esm5	327 kB	327 kB	+34 B (+0.0%)
  main	525 kB	526 kB	+83 B (+0.0%)
  module	264 kB	264 kB	+34 B (+0.0%)
  react-native	264 kB	264 kB	+34 B (+0.0%)

• @firebase/firestore-lite

  Type	Base (0361bf3)	Merge (1eeecde)	Diff
  browser	80.8 kB	80.9 kB	+34 B (+0.0%)
  esm5	96.6 kB	96.7 kB	+34 B (+0.0%)
  main	136 kB	136 kB	+83 B (+0.1%)
  module	80.8 kB	80.9 kB	+34 B (+0.0%)
  react-native	81.0 kB	81.1 kB	+34 B (+0.0%)

• bundle

  Type	Base (0361bf3)	Merge (1eeecde)	Diff
  firestore (Transaction)	184 kB	184 kB	+34 B (+0.0%)
  firestore-lite (Transaction)	80.4 kB	80.5 kB	+34 B (+0.0%)

• firebase

  Type	Base (0361bf3)	Merge (1eeecde)	Diff
  firebase-compat.js	739 kB	739 kB	+36 B (+0.0%)
  firebase-firestore-compat.js	314 kB	314 kB	+36 B (+0.0%)
  firebase-firestore-lite.js	86.2 kB	86.3 kB	+34 B (+0.0%)
  firebase-firestore.js	313 kB	313 kB	+34 B (+0.0%)

Test Logs

• Base (0361bf3): https://github.com/firebase/firebase-js-sdk/actions/runs/2906492913
• Merge (1eeecde): https://github.com/firebase/firebase-js-sdk/actions/runs/2908349615

1. https://storage.googleapis.com/firebase-sdk-metric-reports/B24XkO3UsH.html

[google-oss-bot]

Size Analysis Report ¹

Affected Products

• @firebase/firestore

  • runTransaction

    Size

    Type	Base (0361bf3)	Merge (1eeecde)	Diff
    size	116 kB	116 kB	+33 B (+0.0%)
    size-with-ext-deps	177 kB	177 kB	+34 B (+0.0%)

Test Logs

• Base (0361bf3): https://github.com/firebase/firebase-js-sdk/actions/runs/2906492913
• Merge (1eeecde): https://github.com/firebase/firebase-js-sdk/actions/runs/2908349615

1. https://storage.googleapis.com/firebase-sdk-metric-reports/3qs6w3fR09.html

[dconeybe]

NOTE: This PR introduced a bug: #6659 "transaction.get(ref) followed by transaction.set(ref, {...}) is causing the transaction to fail with error 'Document already exists' if the document was created by another app between the get and set."

The fix will be to consider ALREADY_EXISTS a retryable failure (currently, it is considered a permanent failure) so that the transaction will simply be retried.