Fix webchannel wrapper overrides #7593

wu-hui · 2023-08-29T13:35:43Z

Followup fix of #7569

changeset-bot · 2023-08-29T13:35:48Z

🦋 Changeset detected

Latest commit: b798012

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@firebase/firestore	Patch
@firebase/webchannel-wrapper	Patch
firebase	Patch
@firebase/firestore-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2023-08-29T13:58:34Z

Size Report ¹

Affected Products

@firebase/webchannel-wrapper
Type Base (25cda8a) Merge (7a9b4f5) Diff
esm5 55.4 kB 55.4 kB +13 B (+0.0%)
main 65.4 kB 65.4 kB +13 B (+0.0%)
module 53.1 kB 53.1 kB +13 B (+0.0%)

`bundle`

Type	Base (`25cda8a`)	Merge (`7a9b4f5`)	Diff
firestore (Persistence)	302 kB	302 kB	+13 B (+0.0%)
firestore (Query Cursors)	239 kB	239 kB	+13 B (+0.0%)
firestore (Query)	237 kB	237 kB	+13 B (+0.0%)
firestore (Read data once)	224 kB	224 kB	+13 B (+0.0%)
firestore (Realtime updates)	226 kB	226 kB	+13 B (+0.0%)
firestore (Transaction)	204 kB	204 kB	+13 B (+0.0%)
firestore (Write data)	204 kB	204 kB	+13 B (+0.0%)

firebase
Type Base (25cda8a) Merge (7a9b4f5) Diff
firebase-compat.js 779 kB 779 kB +13 B (+0.0%)
firebase-firestore-compat.js 341 kB 341 kB +13 B (+0.0%)
firebase-firestore.js 435 kB 435 kB +13 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/7GvtYI1fND.html

google-oss-bot · 2023-08-29T14:14:56Z

Size Analysis Report ¹

Affected Products

@firebase/firestore
- AbstractUserDataWriter
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 95.4 kB 95.4 kB +13 B (+0.0%)
- AggregateField
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.4 kB 87.4 kB +13 B (+0.0%)
- AggregateQuerySnapshot
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.5 kB 87.5 kB +13 B (+0.0%)
- Bytes
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 88.9 kB 88.9 kB +13 B (+0.0%)
- CACHE_SIZE_UNLIMITED
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.3 kB 87.4 kB +13 B (+0.0%)
- CollectionReference
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 91.0 kB 91.0 kB +13 B (+0.0%)
- DocumentReference
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 91.0 kB 91.0 kB +13 B (+0.0%)
- DocumentSnapshot
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 94.5 kB 94.5 kB +13 B (+0.0%)
- FieldPath
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 90.0 kB 90.0 kB +13 B (+0.0%)
- FieldValue
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.4 kB 87.4 kB +13 B (+0.0%)
- Firestore
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.3 kB 87.3 kB +13 B (+0.0%)
- FirestoreError
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.3 kB 87.3 kB +13 B (+0.0%)
- GeoPoint
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.9 kB 87.9 kB +13 B (+0.0%)
- LoadBundleTask
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 88.2 kB 88.2 kB +13 B (+0.0%)
- PersistentCacheIndexManager
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.4 kB 87.4 kB +13 B (+0.0%)
- Query
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.5 kB 87.5 kB +13 B (+0.0%)
- QueryCompositeFilterConstraint
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 90.6 kB 90.7 kB +13 B (+0.0%)
- QueryConstraint
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.4 kB 87.4 kB +13 B (+0.0%)
- QueryDocumentSnapshot
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 94.5 kB 94.5 kB +13 B (+0.0%)
- QueryEndAtConstraint
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 106 kB 106 kB +13 B (+0.0%)
- QueryFieldFilterConstraint
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 112 kB 112 kB +13 B (+0.0%)
- QueryLimitConstraint
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 88.1 kB 88.1 kB +13 B (+0.0%)
- QueryOrderByConstraint
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 89.2 kB 89.2 kB +13 B (+0.0%)
- QuerySnapshot
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 96.4 kB 96.4 kB +13 B (+0.0%)
- QueryStartAtConstraint
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 106 kB 106 kB +13 B (+0.0%)
- SnapshotMetadata
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.5 kB 87.5 kB +13 B (+0.0%)
- Timestamp
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 88.5 kB 88.5 kB +13 B (+0.0%)
- Transaction
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 121 kB 121 kB +13 B (+0.0%)
- WriteBatch
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 118 kB 118 kB +13 B (+0.0%)
- _ByteString
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 88.4 kB 88.4 kB +13 B (+0.0%)
- _DatabaseId
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.3 kB 87.3 kB +13 B (+0.0%)
- _DocumentKey
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 96.7 kB 96.7 kB +13 B (+0.0%)
- _EmptyAppCheckTokenProvider
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.4 kB 87.4 kB +13 B (+0.0%)
- _EmptyAuthCredentialsProvider
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.3 kB 87.4 kB +13 B (+0.0%)
- _FieldPath
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 89.8 kB 89.8 kB +13 B (+0.0%)
- _TestingHooks
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.8 kB 87.8 kB +13 B (+0.0%)
- _cast
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 88.1 kB 88.1 kB +13 B (+0.0%)
- _debugAssert
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.3 kB 87.4 kB +13 B (+0.0%)
- _isBase64Available
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.4 kB 87.4 kB +13 B (+0.0%)
- _logWarn
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.4 kB 87.4 kB +13 B (+0.0%)
- _validateIsNotUsedTogether
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.3 kB 87.3 kB +13 B (+0.0%)
- addDoc
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 194 kB 194 kB +13 B (+0.0%)
- aggregateFieldEqual
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.7 kB 87.7 kB +13 B (+0.0%)
- aggregateQuerySnapshotEqual
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 104 kB 104 kB +13 B (+0.0%)
- and
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 113 kB 113 kB +13 B (+0.0%)
- arrayRemove
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 100 kB 100 kB +13 B (+0.0%)
- arrayUnion
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 100 kB 100 kB +13 B (+0.0%)
- average
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 91.1 kB 91.1 kB +13 B (+0.0%)
- clearIndexedDbPersistence
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 96.3 kB 96.3 kB +13 B (+0.0%)
- collection
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 91.7 kB 91.7 kB +13 B (+0.0%)
- collectionGroup
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 90.7 kB 90.7 kB +13 B (+0.0%)
- connectFirestoreEmulator
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 89.7 kB 89.7 kB +13 B (+0.0%)
- count
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.5 kB 87.5 kB +13 B (+0.0%)
- deleteAllPersistentCacheIndexes
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 157 kB 157 kB +13 B (+0.0%)
- deleteDoc
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 185 kB 185 kB +13 B (+0.0%)
- deleteField
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.7 kB 87.7 kB +13 B (+0.0%)
- disableNetwork
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 173 kB 173 kB +13 B (+0.0%)
- disablePersistentCacheIndexAutoCreation
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 157 kB 157 kB +13 B (+0.0%)
- doc
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 91.8 kB 91.8 kB +13 B (+0.0%)
- documentId
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 90.1 kB 90.1 kB +13 B (+0.0%)
- enableIndexedDbPersistence
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 257 kB 257 kB +13 B (+0.0%)
- enableMultiTabIndexedDbPersistence
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 293 kB 293 kB +13 B (+0.0%)
- enableNetwork
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 173 kB 173 kB +13 B (+0.0%)
- enablePersistentCacheIndexAutoCreation
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 157 kB 157 kB +13 B (+0.0%)
- endAt
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 106 kB 106 kB +13 B (+0.0%)
- endBefore
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 106 kB 106 kB +13 B (+0.0%)
- ensureFirestoreConfigured
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.4 kB 87.5 kB +13 B (+0.0%)
- executeWrite
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 184 kB 184 kB +13 B (+0.0%)
- getAggregateFromServer
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 180 kB 180 kB +13 B (+0.0%)
- getCountFromServer
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 180 kB 180 kB +13 B (+0.0%)
- getDoc
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 214 kB 214 kB +13 B (+0.0%)
- getDocFromCache
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 165 kB 165 kB +13 B (+0.0%)
- getDocFromServer
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 214 kB 214 kB +13 B (+0.0%)
- getDocs
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 215 kB 215 kB +13 B (+0.0%)
- getDocsFromCache
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 172 kB 172 kB +13 B (+0.0%)
- getDocsFromServer
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 215 kB 215 kB +13 B (+0.0%)
- getFirestore
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 97.6 kB 97.6 kB +13 B (+0.0%)
- getPersistentCacheIndexManager
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 88.6 kB 88.6 kB +13 B (+0.0%)
- increment
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 88.2 kB 88.2 kB +13 B (+0.0%)
- initializeFirestore
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 88.7 kB 88.7 kB +13 B (+0.0%)
- limit
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 88.3 kB 88.3 kB +13 B (+0.0%)
- limitToLast
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 88.3 kB 88.3 kB +13 B (+0.0%)
- loadBundle
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 182 kB 182 kB +13 B (+0.0%)
- memoryEagerGarbageCollector
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 155 kB 155 kB +13 B (+0.0%)
- memoryLocalCache
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 170 kB 170 kB +13 B (+0.0%)
- memoryLruGarbageCollector
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 162 kB 162 kB +13 B (+0.0%)
- namedQuery
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 158 kB 158 kB +13 B (+0.0%)
- onSnapshot
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 216 kB 216 kB +13 B (+0.0%)
- onSnapshotsInSync
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 205 kB 205 kB +13 B (+0.0%)
- or
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 113 kB 113 kB +13 B (+0.0%)
- orderBy
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 92.7 kB 92.7 kB +13 B (+0.0%)
- persistentLocalCache
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 255 kB 255 kB +13 B (+0.0%)
- persistentMultipleTabManager
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 290 kB 290 kB +13 B (+0.0%)
- persistentSingleTabManager
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 254 kB 254 kB +13 B (+0.0%)
- query
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 114 kB 114 kB +13 B (+0.0%)
- queryEqual
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 104 kB 104 kB +13 B (+0.0%)
- refEqual
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 91.2 kB 91.2 kB +13 B (+0.0%)
- runTransaction
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 194 kB 194 kB +13 B (+0.0%)
- serverTimestamp
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.6 kB 87.6 kB +13 B (+0.0%)
- setDoc
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 193 kB 193 kB +13 B (+0.0%)
- setIndexConfiguration
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 161 kB 161 kB +13 B (+0.0%)
- setLogLevel
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.4 kB 87.4 kB +13 B (+0.0%)
- snapshotEqual
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 109 kB 109 kB +13 B (+0.0%)
- startAfter
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 106 kB 106 kB +13 B (+0.0%)
- startAt
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 106 kB 106 kB +13 B (+0.0%)
- sum
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 91.1 kB 91.1 kB +13 B (+0.0%)
- terminate
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 87.6 kB 87.6 kB +13 B (+0.0%)
- updateDoc
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 193 kB 193 kB +13 B (+0.0%)
- waitForPendingWrites
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 173 kB 173 kB +13 B (+0.0%)
- where
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 113 kB 113 kB +13 B (+0.0%)
- writeBatch
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size-with-ext-deps 195 kB 195 kB +13 B (+0.0%)
@firebase/webchannel-wrapper
- ErrorCode
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size 52.2 kB 52.2 kB +13 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +13 B (+0.0%)
- Event
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size 52.2 kB 52.2 kB +13 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +13 B (+0.0%)
- EventType
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size 52.2 kB 52.2 kB +13 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +13 B (+0.0%)
- FetchXmlHttpFactory
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size 52.2 kB 52.2 kB +13 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +13 B (+0.0%)
- Integer
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size 52.2 kB 52.2 kB +13 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +13 B (+0.0%)
- Md5
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size 52.2 kB 52.2 kB +13 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +13 B (+0.0%)
- Stat
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size 52.3 kB 52.3 kB +13 B (+0.0%)
  size-with-ext-deps 52.3 kB 52.3 kB +13 B (+0.0%)
- WebChannel
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size 52.2 kB 52.2 kB +13 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +13 B (+0.0%)
- XhrIo
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size 52.2 kB 52.2 kB +13 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +13 B (+0.0%)
- createWebChannelTransport
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size 52.5 kB 52.6 kB +13 B (+0.0%)
  size-with-ext-deps 52.5 kB 52.6 kB +13 B (+0.0%)
- default
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size 52.9 kB 52.9 kB +13 B (+0.0%)
  size-with-ext-deps 52.9 kB 52.9 kB +13 B (+0.0%)
- getStatEventTarget
  Size
  Type Base (25cda8a) Merge (7a9b4f5) Diff
  size 52.2 kB 52.3 kB +13 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.3 kB +13 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/juVtJZtnbC.html

dconeybe

LGTM, but you NEED a changeset in order to bump the version and have firestore pick up the change.

.changeset/fresh-frogs-heal.md

Fix webchannel wrapper overrides

33e4c7b

wu-hui requested review from a team as code owners August 29, 2023 13:35

wu-hui requested a review from MarkDuckworth August 29, 2023 15:04

wu-hui assigned dconeybe Aug 29, 2023

wu-hui requested review from dconeybe and removed request for MarkDuckworth August 29, 2023 15:05

dconeybe requested changes Aug 29, 2023

View reviewed changes

dconeybe assigned wu-hui and unassigned dconeybe Aug 29, 2023

Create fresh-frogs-heal.md

4896b0d

wu-hui requested a review from a team as a code owner August 29, 2023 15:53

dconeybe requested changes Aug 29, 2023

View reviewed changes

.changeset/fresh-frogs-heal.md Outdated Show resolved Hide resolved

Update fresh-frogs-heal.md

d605409

dconeybe requested changes Aug 29, 2023

View reviewed changes

.changeset/fresh-frogs-heal.md Outdated Show resolved Hide resolved

Update fresh-frogs-heal.md

b798012

dconeybe approved these changes Aug 29, 2023

View reviewed changes

wu-hui merged commit 60e4a07 into master Aug 29, 2023
43 checks passed

wu-hui deleted the wuandy/WCOverrideFix branch August 29, 2023 18:18

google-oss-bot mentioned this pull request Sep 12, 2023

Version Packages #7626

Merged

firebase locked and limited conversation to collaborators Sep 29, 2023

Fix webchannel wrapper overrides #7593

Fix webchannel wrapper overrides #7593

Conversation

wu-hui commented Aug 29, 2023 • edited Loading

changeset-bot bot commented Aug 29, 2023 • edited Loading

🦋 Changeset detected

google-oss-bot commented Aug 29, 2023 • edited Loading

Size Report 1

Affected Products

@firebase/webchannel-wrapper

bundle

firebase

Test Logs

google-oss-bot commented Aug 29, 2023 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/firestore

AbstractUserDataWriter

AggregateField

AggregateQuerySnapshot

Bytes

CACHE_SIZE_UNLIMITED

CollectionReference

DocumentReference

DocumentSnapshot

FieldPath

FieldValue

Firestore

FirestoreError

GeoPoint

LoadBundleTask

PersistentCacheIndexManager

Query

QueryCompositeFilterConstraint

QueryConstraint

QueryDocumentSnapshot

QueryEndAtConstraint

QueryFieldFilterConstraint

QueryLimitConstraint

QueryOrderByConstraint

QuerySnapshot

QueryStartAtConstraint

SnapshotMetadata

Timestamp

Transaction

WriteBatch

_ByteString

_DatabaseId

_DocumentKey

_EmptyAppCheckTokenProvider

_EmptyAuthCredentialsProvider

_FieldPath

_TestingHooks

_cast

_debugAssert

_isBase64Available

_logWarn

_validateIsNotUsedTogether

addDoc

aggregateFieldEqual

aggregateQuerySnapshotEqual

and

arrayRemove

arrayUnion

average

clearIndexedDbPersistence

collection

collectionGroup

connectFirestoreEmulator

count

deleteAllPersistentCacheIndexes

deleteDoc

deleteField

disableNetwork

disablePersistentCacheIndexAutoCreation

doc

documentId

enableIndexedDbPersistence

enableMultiTabIndexedDbPersistence

enableNetwork

wu-hui commented Aug 29, 2023 •

edited

Loading

changeset-bot bot commented Aug 29, 2023 •

edited

Loading

google-oss-bot commented Aug 29, 2023 •

edited

Loading

Size Report ¹

`@firebase/webchannel-wrapper`

`bundle`

`firebase`

google-oss-bot commented Aug 29, 2023 •

edited

Loading

Size Analysis Report ¹

`@firebase/firestore`

`AbstractUserDataWriter`

`AggregateField`

`AggregateQuerySnapshot`

`Bytes`

`CACHE_SIZE_UNLIMITED`

`CollectionReference`

`DocumentReference`

`DocumentSnapshot`

`FieldPath`

`FieldValue`

`Firestore`

`FirestoreError`

`GeoPoint`

`LoadBundleTask`

`PersistentCacheIndexManager`

`Query`

`QueryCompositeFilterConstraint`

`QueryConstraint`

`QueryDocumentSnapshot`

`QueryEndAtConstraint`

`QueryFieldFilterConstraint`

`QueryLimitConstraint`

`QueryOrderByConstraint`

`QuerySnapshot`

`QueryStartAtConstraint`

`SnapshotMetadata`

`Timestamp`

`Transaction`

`WriteBatch`

`_ByteString`

`_DatabaseId`

`_DocumentKey`

`_EmptyAppCheckTokenProvider`

`_EmptyAuthCredentialsProvider`

`_FieldPath`

`_TestingHooks`

`_cast`

`_debugAssert`

`_isBase64Available`

`_logWarn`

`_validateIsNotUsedTogether`

`addDoc`

`aggregateFieldEqual`

`aggregateQuerySnapshotEqual`

`and`

`arrayRemove`

`arrayUnion`

`average`

`clearIndexedDbPersistence`

`collection`

`collectionGroup`

`connectFirestoreEmulator`

`count`

`deleteAllPersistentCacheIndexes`

`deleteDoc`

`deleteField`

`disableNetwork`

`disablePersistentCacheIndexAutoCreation`

`doc`

`documentId`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`enablePersistentCacheIndexAutoCreation`

`endAt`

`endBefore`

`ensureFirestoreConfigured`

`executeWrite`

`getAggregateFromServer`

`getCountFromServer`