Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webchannel wrapper overrides #7593

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Fix webchannel wrapper overrides #7593

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33e4c7b
Fix webchannel wrapper overrides
wu-hui Aug 29, 2023
4896b0d
Create fresh-frogs-heal.md
wu-hui Aug 29, 2023
d605409
Update fresh-frogs-heal.md
wu-hui Aug 29, 2023
b798012
Update fresh-frogs-heal.md
wu-hui Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/fresh-frogs-heal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@firebase/firestore": patch
"@firebase/webchannel-wrapper": patch
---

Fix webchannel wrapper overrides.js to pick useFetchStreams option.
dconeybe marked this conversation as resolved.
Show resolved Hide resolved
3 changes: 3 additions & 0 deletions packages/webchannel-wrapper/externs/overrides.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ goog.net.WebChannel.Options.forceLongPolling;
/** @type {boolean|undefined} */
goog.net.WebChannel.Options.detectBufferingProxy;

/** @type {boolean|undefined} */
goog.net.WebChannel.Options.useFetchStreams;

/** @type {unknown} */
goog.net.WebChannel.Options.xmlHttpFactory;

Expand Down
Loading