Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump firebase iOS SDK to v11.6.0 #16858

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Dec 11, 2024

Description

  • 1 auth test failing because error code returned when using emulator isn't the same as when running live. It should be invalid-phone-number but it is returning internal-error. The underlying exception is "identitytoolkit.getRecaptchaConfig is not implemented in the Auth Emulator."
  • Another test failing which is also down to this underlying exception: "identitytoolkit.getRecaptchaConfig is not implemented in the Auth Emulator." It shouldn't be failing at all but it seems setting appVerificationDisabledForTesting isn't respected as it should be.

This issue is being tracked on the firebase-ios-sdk here: firebase/firebase-ios-sdk#14242

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley added the blocked: do-not-merge PR blocked externally label Dec 12, 2024
@russellwheatley russellwheatley removed the blocked: do-not-merge PR blocked externally label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant