Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump firebase iOS SDK to v11.6.0 #16858

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# https://firebase.google.com/support/release-notes/ios
def firebase_sdk_version!()
'11.4.0'
'11.6.0'
end
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import 'package:firebase_auth/firebase_auth.dart';
import 'package:firebase_core/firebase_core.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:integration_test/integration_test.dart';
import 'package:tests/firebase_options.dart';
Expand All @@ -24,6 +25,10 @@ void main() {

await FirebaseAuth.instance
.useAuthEmulator(testEmulatorHost, testEmulatorPort);
if (defaultTargetPlatform != TargetPlatform.windows) {
await FirebaseAuth.instance
.setSettings(appVerificationDisabledForTesting: true);
}
});

setUp(() async {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -904,9 +904,13 @@ void main() {

Exception e = await getError();
expect(e, isA<FirebaseAuthException>());

FirebaseAuthException exception = e as FirebaseAuthException;
expect(exception.code, equals('invalid-phone-number'));
// Exception code is returning internal-error but the underlying error is "identitytoolkit.getRecaptchaConfig is not implemented in the Auth Emulator."
// This issue on firebase-ios-sdk: https://github.com/firebase/firebase-ios-sdk/issues/14242. Once this is resolved, we ought to reinstate the below.
// It works fine on live project but returns internal-error on emulator.
if (defaultTargetPlatform != TargetPlatform.iOS) {
FirebaseAuthException exception = e as FirebaseAuthException;
expect(exception.code, equals('invalid-phone-number'));
}
});

test(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,10 @@ void main() {
},
skip: kIsWeb ||
defaultTargetPlatform == TargetPlatform.macOS ||
defaultTargetPlatform == TargetPlatform.windows,
defaultTargetPlatform == TargetPlatform.windows
// on iOS, returning an exception but underlying exception is: "identitytoolkit.getRecaptchaConfig is not implemented in the Auth Emulator."
// which might be a result of this issue: https://github.com/firebase/firebase-ios-sdk/issues/14242. Once resolved, try to reinstate.
|| defaultTargetPlatform == TargetPlatform.iOS,
); // verifyPhoneNumber not supported on web.

test(
Expand Down
Loading