Gusto integration #104
Draft
Gusto integration #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JHopeCollins
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently keep the compatible finite element spaces/forms for the atmospheric examples in the utils folder. Gusto can provide these for us if we can interface properly with their Equation classes.
We can do this via the labelling in the form manipulation language. Gusto label the time derivative terms in the equation forms, which means that we can make functions to pick out the time derivatives for the
form_massargument toparadiag, and remove the time derivatives for theform_functionargument.This relies on Gusto PRs #322 and #325 to be able to replace the test/trial/subject functions in the Equation forms with the appropriate components of the all-at-once mixed function space.