-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Allow indexing in replace_test_function
and replace_trial_function
maps.
#325
Conversation
…g replace dictionary
To allow adding the
When I was refactoring I ran into into issues with having to check for extra (valid) type combinations between the new/old values. But 1. is really just asking "will |
I merged main into this branch and I'm now seeing errors when trying to use Failing example:
Replacing the indexed test functions works (yay!), but replacing the split subject does not. Replacing the unsplit subject works as before. The last two lines produce the following errors, but don't error if the Error for break 1:
Error for break 2:
I'm not entirely sure what the fix in #346 is doing or why it is necessary, so I don't really know how to go about fixing this. @jshipton @tommbendall any ideas? |
This will allow passing an
idx
argument toreplace_test_function
andreplace_trial_function
in the same way asreplace_subject
, which will help when dealing with mixed spaces.