Fix 2 d perp #346
Merged
Fix 2 d perp #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect is replaced as otherwise replace can no longer find the subject
tommbendall
requested changes
Jan 24, 2023
tommbendall
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Thanks, all looks great now. And good to know we're also completing issue #272 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with
ufl.replacenot finding the perp of a function defined on a subcomponent of a mixed function space. This affects shallow water simulations in the plane. The fix is to label (of course!) the Coriolis term with a label calledperp, who's value is the function that defines the perp operator. This means that we can delay the application of the perp operator until after the subject of the form has been replaced. Ideally we would find a better fix for this...