Another perp fix #362
Merged
Another perp fix #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g replace dictionary
… another_perp_fix
… another_perp_fix
…n provided in data directory
tommbendall
requested changes
Apr 14, 2023
|
@JHopeCollins are you able to edit the PR description to include a bit about what changed in your branch? |
I've added a description of those additions and a link to my original PR. |
tommbendall
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue that ufl.replace doesn't replace perp(u) on the plane (because it doesn't see the relationship between [u0, u1] and [-u1, u0]). The fix is to label the terms for which this is a problem and then the Gusto replace functions pass perp(u) to ufl.replace.
This includes a test comparing to benchmarked known good values.
This PR also includes the edits introduced in #325. That PR refactors the logic in
replace_{test,trial,subject}for building the dictionary to pass toufl.replace. This simplifies the logic a bit (most type checking is deferred touflinstead of being carried out by gusto), and allows it to be share between the three functions. It also adds the ability to pass an index toreplace_{test,trial}when the new and/or old value is from a mixed space, which was previously only possible withreplace_subject.