Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule creates duplicate destination accounts #395

Closed
marcoveeneman opened this issue Nov 8, 2016 · 9 comments
Closed

Rule creates duplicate destination accounts #395

marcoveeneman opened this issue Nov 8, 2016 · 9 comments

Comments

@marcoveeneman
Copy link

Hi,

To merge the Albert Heijn related accounts into a single one i tried using the following transaction rule:
image

This created 10s of different expense accounts named Albert Heijn, each account having a single transaction. I expected a single Albert Heijn account to be created with all the transactions belonging there. Re-running the rule group created another list of Albert Heijn accounts and made the older ones empty.

image

I'm using version 4.1.6

@JC5
Copy link
Member

JC5 commented Nov 8, 2016

Lol whoops. There should be a single one, yes. I'll check it out and push a fix. Skip the rule action for now, new release will be this weekend.

@marcoveeneman
Copy link
Author

Thanks. I will wait for a fix then :)

JC5 added a commit that referenced this issue Nov 8, 2016
@JC5
Copy link
Member

JC5 commented Nov 8, 2016

If you want to fix this yourself to be able to continue, open the file called app/Rules/Actions/SetDestinationAccount.php.

On line 126, you should find the word "REVENUE". Replace this word with EXPENSE, like so.

That should fix it.

@marcoveeneman
Copy link
Author

Thank you for the quick fix! I can confirm this works.
I had to change the destination account to another name, e.g. 'Albert Heijn 2', to get all transactions in that single account.

@marcoveeneman
Copy link
Author

Maybe a bit offtopic, but is there a way to select/delete multiple accounts at once, like transactions? I have a bunch of duplicate accounts left now.

@JC5
Copy link
Member

JC5 commented Nov 8, 2016

I'm afraid not :(

On Nov 8, 2016 21:55, "marcoveeneman" notifications@github.com wrote:

Maybe a bit offtopic, but is there a way to select/delete multiple
accounts at once, like transactions? I have a bunch of duplicate accounts
left now.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#395 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFnfwODDyUYhs5sLbwHLET9Oi8SMnYfLks5q8OHIgaJpZM4Ks3UD
.

@marcoveeneman
Copy link
Author

Ok. I started to remove them by hand and now got this fatal error:

( ! ) Fatal error: Class Symfony\Component\Finder\Iterator\FileTypeFilterIterator contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (FilterIterator::accept) in C:\wamp64\www\firefly-iii\vendor\symfony\finder\Iterator\FileTypeFilterIterator.php on line 19
Call Stack
#   Time    Memory  Function    Location
1   0.0010  369752  {main}( )   ...\index.php:0
2   0.0360  3696224 Illuminate\Foundation\Http\Kernel->handle( )    ...\index.php:62
3   0.0360  3696224 Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter( )  ...\Kernel.php:116
4   0.0360  3720304 Illuminate\Foundation\Http\Kernel->bootstrap( ) ...\Kernel.php:144
5   0.0360  3720304 Illuminate\Foundation\Application->bootstrapWith( ) ...\Kernel.php:253
6   0.0516  3887872 Illuminate\Foundation\Bootstrap\LoadConfiguration->bootstrap( ) ...\Application.php:203
7   0.0516  3904728 Illuminate\Foundation\Bootstrap\LoadConfiguration->loadConfigurationFiles( )    ...\LoadConfiguration.php:38
8   0.0516  3904728 Illuminate\Foundation\Bootstrap\LoadConfiguration->getConfigurationFiles( ) ...\LoadConfiguration.php:59
9   0.0516  3980008 Symfony\Component\Finder\Finder->files( )   ...\LoadConfiguration.php:76
10  0.0516  3980008 spl_autoload_call ( )   ...\Finder.php:101
11  0.0516  3980184 Composer\Autoload\ClassLoader->loadClass( ) ...\Finder.php:101
12  0.0516  3980184 Composer\Autoload\includeFile( )    ...\ClassLoader.php:301
13  0.0516  3986136 include( 'C:\wamp64\www\firefly-iii\vendor\symfony\finder\Iterator\FileTypeFilterIterator.php' )    ...\ClassLoader.php:414

@JC5
Copy link
Member

JC5 commented Nov 9, 2016

I've never seen that one before. Try clearing it your cache (php artisan cache:clear) and run composer install --no-dev.

@JC5 JC5 closed this as completed Nov 9, 2016
@JC5 JC5 reopened this Nov 9, 2016
@marcoveeneman
Copy link
Author

marcoveeneman commented Nov 9, 2016

I ran both commands and now get the following error:

( ! ) Fatal error: Class Symfony\Component\Finder\Iterator\PathFilterIterator contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (FilterIterator::accept) in C:\wamp64\www\firefly-iii\bootstrap\cache\compiled.php on line 16874
Call Stack
#   Time    Memory  Function    Location
1   0.0000  367144  {main}( )   ...\index.php:0
2   0.0000  369008  require( 'C:\wamp64\www\firefly-iii\bootstrap\autoload.php' )   ...\index.php:31

EDIT: Ok i rebooted the wamp server and now it seems to work.. Thank you.

@JC5 JC5 closed this as completed Nov 9, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants