Spend creation improved #1032
Merged
Spend creation improved #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging c8a1796 into 677b54c - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 6ecae1b into 677b54c - view on LGTM.com new alerts:
|
a-bezrukov
approved these changes
May 17, 2021
psolstice
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces disk access during joinsplit creation, also fixed error messages when number of inputs exceeds the limit.
EstimateJoinSplitFee() was calling GetAvailableCoins() and GetAvailableLelantusCoins() functions, both are expensive as both are doing disk accesses.
The changes just passes already gotten vectors, as we have it in LelantusJoinSplitBuilder::Build() function.