Fixing sigma->lelantus joinsplit tx at Transaction tab #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 3 alerts when merging a80740d into 1f2121a - view on LGTM.com fixed alerts:
|
a-bezrukov
approved these changes
Jan 30, 2021
psolstice
approved these changes
Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes transaction entry at Transaction tab, when you are spending Sigma mint with Lelantus to third party address,
Please merge #971 fist
It was showing joinsplit transaction entry wrongly in Transaction tab, when it was spending sigma coins, the reason was that there was missing code to create CSigmaSpendEntry objects for each spent serial number, which is used for UI to determine if the spend is from you or not.