Fix for coin not found issue. #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
levonpetrosyan93
commented
Jan 17, 2021
•
levonpetrosyan93
commented
- Fix for sigma hd mint bug, where coin group id is not being set, it results an coin not found in chin issue during Lelantus joinsplit creation, The reason wast that, setting group id in SetMintSeedSeen() was missing, and it was remaining -1 in sum circumstances, the code is adding that,
- Making error messages more accurate.
psolstice
requested changes
Jan 28, 2021
|
|
||
| int id; | ||
| std::tie(std::ignore, id) = sigma::CSigmaState::GetState()->GetMintedCoinHeightAndId(sigma::PublicCoin(bnValue, denom)); | ||
|
|
||
| // Create mint object | ||
| CHDMint dMint(mintCount, seedId, hashSerial, bnValue); | ||
| int64_t amount; | ||
| DenominationToInteger(denom, amount); | ||
| dMint.SetAmount(amount); | ||
| dMint.SetHeight(nHeight); |
There was a problem hiding this comment.
nHeight is passed to this function as const int & which is something really weird. Please change it to just int
levonpetrosyan93
force-pushed
the
coin_notfound_fix
branch
from
928fcc6
to
8fd9be8
Compare
psolstice
approved these changes
Jan 28, 2021
|
This pull request introduces 3 alerts when merging 8fd9be8 into 5525561 - view on LGTM.com new alerts:
|
a-bezrukov
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.