Llmq improvements #978
Merged
Llmq improvements #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psolstice
requested changes
Jan 21, 2021
src/init.cpp
Outdated
| @@ -2049,8 +2047,6 @@ bool AppInitMain(boost::thread_group& threadGroup, CScheduler& scheduler) | |||
| activeMasternodeInfo.blsPubKeyOperator = std::make_unique<CBLSPublicKey>(); | |||
| } | |||
|
|
|||
| // ********************************************************* Step 10b: schedule Dash-specific tasks | |||
|
|
|||
There was a problem hiding this comment.
why this comment has to be removed? it's a messy init process, good to break it in stages
src/validation.cpp
Outdated
| return error("ConnectBlock(): ProcessSpecialTxsInBlock for block %s failed with %s", | ||
| pindex->GetBlockHash().ToString(), FormatStateMessage(state)); | ||
| return error("ConnectBlock(): ProcessSpecialTxsInBlock for block height %i failed with %s", | ||
| pindex->nHeight, FormatStateMessage(state)); |
There was a problem hiding this comment.
hard to debug in case of competing chains while having only height
configure.ac
Outdated
| @@ -3,7 +3,7 @@ AC_PREREQ([2.60]) | |||
| define(_CLIENT_VERSION_MAJOR, 0) | |||
| define(_CLIENT_VERSION_MINOR, 14) | |||
| define(_CLIENT_VERSION_REVISION, 3) | |||
psolstice
previously approved these changes
Jan 21, 2021
levonpetrosyan93
previously approved these changes
Jan 21, 2021
|
This pull request introduces 26 alerts and fixes 10 when merging 9cfcd4b into e743e9c - view on LGTM.com new alerts:
fixed alerts:
|
a-bezrukov
dismissed stale reviews from levonpetrosyan93 and psolstice
via
f8a7a84
a-bezrukov
force-pushed
the
llmq_improvements
branch
from
9cfcd4b
to
f8a7a84
Compare
levonpetrosyan93
previously approved these changes
Jan 21, 2021
a-bezrukov
force-pushed
the
llmq_improvements
branch
from
f8a7a84
to
9cbc32a
Compare
levonpetrosyan93
approved these changes
Jan 21, 2021
psolstice
approved these changes
Jan 21, 2021
|
This pull request introduces 24 alerts and fixes 13 when merging 9cbc32a into e743e9c - view on LGTM.com new alerts:
fixed alerts:
|
reubenyap
pushed a commit
that referenced
this pull request
Jan 30, 2021
* Copying unstripped binaries * Debuginfo for OSx * Debuginfo for OSx * Debuginfo for OSx * Reset macos changes * Llmq improvements (#978) * Removed znode-payments * Znodesync-interface cleaned * darksend has been dealt with * Removed RPC broadcast * Znode GUI removed * Removed znodeman * Removed znode-sync * Removed activeznode * Removed ping and broadcast * Removed znode * Removed from GUI and net exchange * Removed -znodeprivkey * Removed znode-payments * Znodesync-interface cleaned * darksend has been dealt with * Removed RPC broadcast * Znode GUI removed * Removed znodeman * Removed znode-sync * Removed activeznode * Removed ping and broadcast * Removed znode * Removed from GUI and net exchange * Removed -znodeprivkey * Tests are adjusted * Removed sporks * Cleanup in comments, other minor clean-ups * Stopped using *.dat cache files * Minor improvements for LLMQs * Minor improvements for LLMQs * All LLMQ tests are done * Llmqs for chainlocks were enabled * Chainlocks start working * Wrapping up with chainlocks * Removed znode-payments * Znodesync-interface cleaned * darksend has been dealt with * Removed znodeman * Removed znode * Cleanup in comments, other minor clean-ups * Minor improvements for LLMQs * All LLMQ tests are done * Llmqs for chainlocks were enabled * Chainlocks start working * Wrapping up with chainlocks * Tests are fixed * Removed the original test * Evospork controls chainlocks * More tests for CL * Blockchain params change for testnet * Formatting fix * Minor improvments * Dealing with the code review comments * Version update * HF date is set * Minor cleanup * Dealing with code review Co-authored-by: Andrey <andrey@zcoin.io> Co-authored-by: Peter Shugalev <peter@shugalev.com> * Copying unstripped binaries * Debuginfo for OSx * Debuginfo for OSx * Debuginfo for OSx * Reset macos changes Co-authored-by: Andrey <andrey@zcoin.io> Co-authored-by: Peter Shugalev <peter@shugalev.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Chainlocks is a mechanism for near-instant confirmation of blocks and finding near-instant consensus on the longest valid/accepted chain. It implements the Dash DIP0008 functionality.
Code changes brief