Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don’t add the commit body text to issue subject #152

Closed
gr2m opened this issue Oct 14, 2017 · 4 comments
Closed

don’t add the commit body text to issue subject #152

gr2m opened this issue Oct 14, 2017 · 4 comments

Comments

@gr2m
Copy link
Contributor

gr2m commented Oct 14, 2017

it currently puts both the commit subject and body into the issue subject. I’ve fixed it now on the issue

image

The issue is hoodiehq/camp#126
The commit is hoodiehq/hoodie-account-server-api@3a30757

We should instead make the issue body another placeholder in the template :)

@pathawks
Copy link
Contributor

I wonder if the original committer could be added to the issue template as well. That would allow things like:

Comments from $COMMITTER:
> $MESSAGE

@gr2m
Copy link
Contributor Author

gr2m commented Oct 18, 2017

with "original committer" you mean the person who created the first-timers-... branch? I like the idea! What would the value of $COMMITTER be? Username? Name?

@pathawks
Copy link
Contributor

Right, the person who created the branch.

The value of $COMMITTER should be that person’s GitHub username in the form @pathawks. This would cause the generated issue to appear in the list of issues I am mentioned in, and make it obvious who could answer any questions about the changes.

@gr2m
Copy link
Contributor Author

gr2m commented Feb 28, 2018

we will call the variable $AUTHOR and it will be the commit author’s github username. Committer & author are two different things, the author refers to the person who made the commit. Someone else can be the committer, e.g. a maintainer squashed & merged a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants