Exclude commit description from issue titles and add $AUTHOR value for issue templates #186
Conversation
lib/get-commit.js
Outdated
| @@ -17,7 +17,8 @@ function getCommit (state) { | |||
| message: result.data.commit.message, | |||
| filename, | |||
| patch, | |||
| branchUrl: branchUrl | |||
| branchUrl: branchUrl, | |||
| committer: result.data.author.login | |||
There was a problem hiding this comment.
Instead of commiter I would suggest to set authorLogin.
Author is the person who created the commit, Committer is the person you added the commit to the commit history. See c64b40f for example, in that commit, you are the author, I am the committer. Here is the object you'd receive from the API https://api.github.com/repos/hoodiehq/first-timers-bot/git/commits/c64b40f918d33263e3c6156683c4bec37d4924ab
And just author would imply an object, while authorLogin is unambiguous
|
@synicalsyntax could you see if you can resolve the conflicts and rebase your pull request on latest master? |
synicalsyntax
force-pushed
the
fix-152
branch
from
0a71317
to
88a2a6e
Compare
lib/create-issue.js
Outdated
| const content = state.template | ||
| .replace(/\$DIFF/, patch) | ||
| .replace(/\$FILENAME/, filename) | ||
| .replace(/\$BRANCH_URL/, branchUrl) | ||
| .replace(/\$REPO/, state.installRepo) | ||
| .replace(/\$COMMITTER/, `@${committer}`) |
There was a problem hiding this comment.
can you please rename $COMMITTER to $AUTHOR and committer to authorLogin
synicalsyntax
changed the title
synicalsyntax
force-pushed
the
fix-152
branch
from
88a2a6e
to
b1e2120
Compare
|
🎉 Thank you so much @synicalsyntax 👍 |
Fixes #152