uptick microsoft ads #112
Merged
uptick microsoft ads #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
@fivetran-jamie thanks for opening this PR! This looks good to me, just one small request to reword the CHANGELOG a bit.
packages.yml
Outdated
Comment on lines
17
to
20
| - package: fivetran/microsoft_ads | ||
| version: [">=0.7.0", "<0.8.0"] | ||
| # - package: fivetran/microsoft_ads | ||
| # version: [">=0.8.0", "<0.9.0"] | ||
| - git: https://github.com/fivetran/dbt_microsoft_ads.git | ||
| revision: bugfix/campaign-report-add-budget |
There was a problem hiding this comment.
Reminder to swap before release
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
fivetran/dbt_microsoft_ads_source#30 by way of including fivetran/dbt_microsoft_ads_source#31
This PR will result in the following new package version:
v0.1.8.0
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
❗ Special Updates for Ad Reporting ❗
To reduce integration testing time, not all models should be enabled in the
run_models.shvars. Update the variables afterdbt runanddbt testto set:truetrue(if not already)falseDetailed Validation
Please share any and all of your validation steps:
see validations in fivetran/dbt_microsoft_ads#32
If you had to summarize this PR in an emoji, which would it be?
🤹