Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new budget fields to campaign_daily_report + adjust uniqueness test #31

Merged
merged 8 commits into from
Jul 15, 2024

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Jul 9, 2024

PR Overview

This PR will address the following Issue/Feature:
#30

This PR will result in the following new package version:

v0.9.0 -- new fields and new grain of PK testing

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fixes

  • Accommodates the recent addition of the budget_name and budget_status fields to the CAMPAIGN_PERFORMANCE_DAILY_REPORT source table. These fields are now:
    • Included and documented in the stg_microsoft_ads__campaign_daily_report model.
    • Included in uniqueness tests on stg_microsoft_ads__campaign_daily_report, as they affect the grain of the report and may have therefore induced uniqueness test failures.
  • Added proper documentation for the pre-existing budget_association_status field (also from CAMPAIGN_PERFORMANCE_DAILY_REPORT).

Under the Hood

  • Included auto-releaser GitHub Actions workflow to automate future releases.
  • Updated the PR Templates for package maintainers to our most up-to-date standards.
  • Upgraded integration test dbt-adapter versions.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned.
  • All necessary documentation and version upgrades have been applied.
  • docs were regenerated (unless this PR does not include any code or yml updates).
  • BuildKite integration tests are passing.
  • Detailed validation steps have been provided below.

Detailed Validation

Please share any and all of your validation steps:

See consistency validations in fivetran/dbt_microsoft_ads#32

Moreover, can confirm that the new fields show up in the staging model
image

If you had to summarize this PR in an emoji, which would it be?

💸

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie thanks for the quick work on this PR! This looks good to me with one small request to reword the CHANGELOG.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie Just a doc suggestion here but otherwise lgtm!

models/docs.md Outdated Show resolved Hide resolved
fivetran-jamie and others added 2 commits July 12, 2024 16:01
Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fivetran-jamie fivetran-jamie merged commit 5a8e19e into main Jul 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants