feature/detail-type-addition #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-avinash
requested changes
Apr 19, 2023
There was a problem hiding this comment.
@fivetran-joemarkiewicz Looking mostly good, some minor corrections to potentially address!
CHANGELOG.md
Outdated
| @@ -1,3 +1,8 @@ | |||
| # dbt_quickbooks_source v0.7.2 | |||
There was a problem hiding this comment.
Should this be v0.8.0 now (or nothing)? The dbt_project.yml reflects the version. I'm guessing this is getting overwritten in the final release branch so not a huge deal either way.
There was a problem hiding this comment.
Yeah I started adjusting these but then left them as we were going to change them in the release branch anyway.
There was a problem hiding this comment.
Updated to be in line with 0.8.0 release
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
|
Thanks for reviewing @fivetran-avinash!! Just made the updates and it is ready for re-review! |
fivetran-avinash
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: #17
This PR will result in the following new package version:
v0.7.2This PR is only adding a new field to the staging model. Since the field is also added to the respective macro, this will not be a breaking change.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
This PR adds the
detail_typefield to thestg_quickbooks__invoice_linemodel and the correspondingget_invoice_line_columnsmacro to ensure the field is populated even if the source does not have this field.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as “ready for review” the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as “ready for review”:
Validation steps included running the package and seeing the
detail_typeproperly present itself in the staging model.Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🕵️