-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/detail-type-addition #43
Merged
fivetran-joemarkiewicz
merged 12 commits into
release/v0.8.0
from
feature/detail-type-addition
Apr 19, 2023
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
96da680
feature/detail-type-addition
fivetran-joemarkiewicz b33574c
yml update, docs regen, changelog reference
fivetran-joemarkiewicz 0f6ca08
Merge branch 'release/v0.8.0' into feature/detail-type-addition
fivetran-joemarkiewicz 56acd72
discount account id casting
fivetran-joemarkiewicz 9e1fbd5
merge conflicts
fivetran-joemarkiewicz 5a6e91d
Merge branch 'feature/detail-type-addition' of https://github.com/fiv…
fivetran-joemarkiewicz 1dfe105
Update CHANGELOG.md
fivetran-joemarkiewicz 43b06da
Update models/src_quickbooks.yml
fivetran-joemarkiewicz 277ff73
Update models/stg_quickbooks.yml
fivetran-joemarkiewicz 0468b90
review updates
fivetran-joemarkiewicz 1ed6f1a
address merge conflicts
fivetran-joemarkiewicz 37abb79
seed data reflection
fivetran-joemarkiewicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
index,invoice_id,_fivetran_synced,amount,bundle_id,bundle_quantity,description,description_service_date,description_tax_code_id,discount_account_id,discount_class_id,discount_discount_percent,discount_percent_based,discount_tax_code_id,sales_item_account_id,sales_item_class_id,sales_item_discount_amount,sales_item_discount_rate,sales_item_item_id,sales_item_quantity,sales_item_service_date,sales_item_tax_code_id,sales_item_unit_price,sub_total_item_id,item_id,quantity,tax_code_id,account_id | ||
0,35647,2021-01-18 6:16:26,27381.64,211,0.6993497,,,,,,,,,,,,,,,,,,,,,, | ||
5,35647,2021-01-18 6:16:26,24850,,,,,,,,,,,,,,,,,,,,,,,, | ||
2,35647,2021-01-18 6:16:26,0,,,0f9d69329f489637a6ae046f4091e365,,,,,,,,,,,,18,,,NON,,,,,, | ||
4,35647,2021-01-18 6:16:26,0,,,553bf7b55f32b6f7074ae45d987530ce,,,,,,,,,,,,18,,,NON,,,,,, | ||
3,35647,2021-01-18 6:16:26,-4280.01,,,2ae778d8d42424d33b656517b2c892bf,,,,,,,,224,,,,34,0.7,,NON,-6120,,,,, | ||
1,35647,2021-01-18 6:16:26,1748.37,,,,,,,,,,,211,,,,227,0.7,,NON,2500,,,,, | ||
0,40092,2021-01-19 2:18:38,21437.5,212,0.5,,,,,,,,,,,,,,,,,,,,,, | ||
10,40092,2021-01-19 2:18:38,17181.75,,,,,,,,,,,,,,,,,,,,,,,, | ||
4,40092,2021-01-19 2:18:38,0,,,7f3c88bf068c8edd47367bd68c01cd8f,,,,,,,,,,,,18,,,NON,,,,,, | ||
7,40092,2021-01-19 2:18:38,0,,,703d01ddc458e55f5b43da8c88aaa581,,,,,,,,,,,,18,,,NON,,,,,, | ||
index,invoice_id,_fivetran_synced,amount,bundle_id,bundle_quantity,description,description_service_date,description_tax_code_id,discount_account_id,discount_class_id,discount_discount_percent,discount_percent_based,discount_tax_code_id,sales_item_account_id,sales_item_class_id,sales_item_discount_amount,sales_item_discount_rate,sales_item_item_id,sales_item_quantity,sales_item_service_date,sales_item_tax_code_id,sales_item_unit_price,sub_total_item_id,item_id,quantity,tax_code_id,account_id,detail_type | ||
0,35647,2021-01-18 6:16:26,27381.64,211,0.6993497,,,,,,,,,,,,,,,,,,,,,,,SalesItemLineDetail | ||
5,35647,2021-01-18 6:16:26,24850,,,,,,,,,,,,,,,,,,,,,,,,, | ||
2,35647,2021-01-18 6:16:26,0,,,0f9d69329f489637a6ae046f4091e365,,,,,,,,,,,,18,,,NON,,,,,,,SalesItemLineDetail | ||
fivetran-avinash marked this conversation as resolved.
Show resolved
Hide resolved
|
||
4,35647,2021-01-18 6:16:26,0,,,553bf7b55f32b6f7074ae45d987530ce,,,,,,,,,,,,18,,,NON,,,,,,, | ||
3,35647,2021-01-18 6:16:26,-4280.01,,,2ae778d8d42424d33b656517b2c892bf,,,,,,,,224,,,,34,0.7,,NON,-6120,,,,,, | ||
1,35647,2021-01-18 6:16:26,1748.37,,,,,,,,,,,211,,,,227,0.7,,NON,2500,,,,,, | ||
0,40092,2021-01-19 2:18:38,21437.5,212,0.5,,,,,,,,,,,,,,,,,,,,,,,SalesItemLineDetail | ||
10,40092,2021-01-19 2:18:38,17181.75,,,,,,,,,,,,,,,,,,,,,,,,, | ||
4,40092,2021-01-19 2:18:38,0,,,7f3c88bf068c8edd47367bd68c01cd8f,,,,,,,,,,,,18,,,NON,,,,,,,SubTotalLine | ||
7,40092,2021-01-19 2:18:38,0,,,703d01ddc458e55f5b43da8c88aaa581,,,,,,,,,,,,18,,,NON,,,,,,,SubTotalLine |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be v0.8.0 now (or nothing)? The dbt_project.yml reflects the version. I'm guessing this is getting overwritten in the final release branch so not a huge deal either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I started adjusting these but then left them as we were going to change them in the release branch anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to be in line with 0.8.0 release