Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some CMake issues #1310

Merged
merged 4 commits into from
Feb 15, 2022
Merged

Conversation

gergondet
Copy link
Contributor

This PR fix some issues with the CMake scripts that were found using CMake 3.22.2 on Ubuntu 20.04

89d8ac4 is not really an issue but I have been bitten a few times in the past by CMake silently not building hrpsysUtil when it is required downstream so this commit removes the automatic enable/disable behavior in favor of an explicit option (ON by default) that will error out if some dependencies are missing.

@fkanehiro fkanehiro merged commit 3706e7c into fkanehiro:master Feb 15, 2022
@Naoki-Hiraoka
Copy link
Contributor

このPull Requestでmergeされた 89d8ac4 以降、HRP2の制御PCでhrpsys-baseをビルドする際に、-DUSE_HRPSYSUTIL=OFFオプションを付けないと次のようなエラーが出るようになりました。

-- checking for module 'opencv'
--   package 'opencv' not found
-- checking for module 'opencv-2.3.1'
--   package 'opencv-2.3.1' not found
-- checking for module 'opencv4'
--   package 'opencv4' not found
CMake Error at CMakeLists.txt:155 (message):
  OpenCV is required to build hrpsysUtil


-- Configuring incomplete, errors occurred!

-DUSE_HRPSYSUTIL=OFFオプションを付けてビルドすれば、従来通り運用可能です。

@fkanehiro
Copy link
Owner

「従来通り」はhrpsysUtilあり、なし、のどちらでしょうか。

@Naoki-Hiraoka
Copy link
Contributor

hrpsysUtilなし、です。

@fkanehiro
Copy link
Owner

なるほど。
従来は、必要なものが入っていればビルドする、というふうになっており、必要なものが入っていないと、ビルドしてほしいと思っていてもエラーなくビルドせずに終わってしまい、わかりにくいというのがこのPRの指摘かと思います。
お手数ですが、オプションの指定をお願いします。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants