attributes publisher #4
Conversation
|
also can we make sure we match L1 payload attribute SSE stream as closely as possible? ethereum/beacon-APIs#244 |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
op-node/node/node.go
Outdated
|
|
||
| mux := http.NewServeMux() | ||
| mux.HandleFunc("/events", eventStream.HTTPHandler) | ||
| addr := net.JoinHostPort(cfg.RPC.ListenAddr, strconv.Itoa(cfg.RPC.ListenPort+1)) |
There was a problem hiding this comment.
can the rpc server not be reused for the event stream? Otherwise the address and port of the SSE stream should be a flag / config
op-node/node/node.go
Outdated
| n.log.Warn("failed to marshal payload attributes", "err", err) | ||
| return err | ||
| } | ||
| n.log.Info("Publishing execution payload attributes on event stream", "attrs", builderAttrs, "json", string(jsonBytes)) |
There was a problem hiding this comment.
is "json", string(jsonBytes) left from debugging? logs would be quite verbose
op-node/rollup/clsync/clsync.go
Outdated
| func (eq *CLSync) PublishAttributes(ctx context.Context, l2head eth.L2BlockRef) error { | ||
| l1Origin, err := eq.l1OriginSelector.FindL1Origin(ctx, l2head) | ||
| if err != nil { | ||
| eq.log.Error("Error finding next L1 Origin", "err", err) |
There was a problem hiding this comment.
is there a need to log errors here when its logged in https://github.com/flashbots/optimism/pull/4/files#diff-606b28086f5f2338fa6ed7aabc59df9d304de4c88d2cbabc7228be5da9592abaR141
| withParent := &derive.AttributesWithParent{ | ||
| Attributes: attrs, | ||
| Parent: l2head, | ||
| IsLastInSpan: false, |
There was a problem hiding this comment.
what is IsLastInSpan used for?
There was a problem hiding this comment.
the derivation pipeline inserts blocks in batch which they call it a span. If it is the last block in span, it sets that to the safe head.
There was a problem hiding this comment.
since we are inserting unsafe payloads it should be set to false
| transactions := make([]*types.Transaction, len(a.Attributes.Transactions)) | ||
| for i, txBytes := range a.Attributes.Transactions { | ||
| var ttx types.Transaction | ||
| ttx.UnmarshalBinary(txBytes) |
There was a problem hiding this comment.
I think this can return an error, good to log something here at least
There was a problem hiding this comment.
fixed to return error properly fd07061
| ParentBeaconBlockRoot *common.Hash `json:"parentBeaconBlockRoot"` | ||
| Transactions types.Transactions `json:"transactions"` | ||
| GasLimit uint64 `json:"gasLimit"` | ||
| NoTxPool bool `json:"noTxPool,omitempty"` |
There was a problem hiding this comment.
what is NoTxPool? its not set in ToBuilderPayloadAttributes()
There was a problem hiding this comment.
it is used for a block that only contains deposit txs. it was my mistake to leave it unset
No description provided.