forked from ethereum-optimism/optimism
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attributes publisher #4
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
03f6065
attributes publisher
jinmel 9ce7434
add l1OriginSelector and attrBuilder to driver
jinmel 56f6a75
remove unused field
jinmel 25103a7
docker compose file for testing
jinmel 8853c0e
move attribute publishing to CLsync
jinmel c1e2a79
wsutils
jinmel 2cb9441
improve broadcasting
jinmel 0712ce3
add sse server options
jinmel 35980e0
remove wss implementation
jinmel 03d1b5e
event server with native feeds
jinmel 8a26c80
remove ReadTimeout and IdleTimeout
jinmel 821cd34
switch back to CL sync
jinmel 1640fad
verbose logging for builder-op-geth
jinmel 31b35dc
remove event server
jinmel f3f43fd
add PublishPayloadAttributes flag
jinmel 403fb23
rename SequencerPublishPayloadAttributes to SequencerPublishAttributes
jinmel 2ba4f88
typo fix
jinmel 9a0e248
use flags to control publish attributes
jinmel 4c7f750
adds unit test for clsync
jinmel 9b66f1d
cleanup debug logs
jinmel e1c790a
cleanup logs in clsync
jinmel fd07061
return error when UnmarshalBinary fails
jinmel 27754df
set NoTxPool
jinmel c965a08
remove debug logs
jinmel 807badf
restore plasma.da-service arg
jinmel 072acf5
remove wsutil package
jinmel b853aaf
remove events server
jinmel 69f4388
Add EventStreamConfig and flags
jinmel 76b8f69
Merge remote-tracking branch 'flashbots/fjord' into fb-op-node
jinmel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is
IsLastInSpan
used for?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the derivation pipeline inserts blocks in batch which they call it a span. If it is the last block in span, it sets that to the safe head.
optimism/op-node/rollup/attributes/attributes.go
Line 133 in f8143c8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we are inserting unsafe payloads it should be set to
false