make 3 casts explicit #1523

videlec · 2023-10-12T19:05:10Z

Three explicit cast that allows compilation with strict C++ compilers.

albinahlback · 2023-10-12T20:51:32Z

src/calcium.h

@@ -58,7 +58,7 @@ CALCIUM_INLINE
 void calcium_stream_init_str(calcium_stream_t out)
 {
    out->fp = NULL;
-    out->s = flint_malloc(16);
+    out->s = (char *) flint_malloc(16);


Why would you need to cast a void *?

Invalid in C++.

We - write down a script to auto-generate flint header files (currently at https://github.com/videlec/flint-header-sage-autogen) - replace most of the files in `src/sage/libs/flint` by auto-generated files. Doing so, the custom sage code in `src/sage/libs/flint` is always contained in files suffixed by `_sage.pxd`/`_sage.pyx`. - deprecate the files in `src/sage/libs/arb/` ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies sagemath#35848 #### Upstream issues and patches - flintlib/flint#1523 - flintlib/flint#1529 - flintlib/flint#1532 - flintlib/flint#1535 - flintlib/flint#1536 - cython/cython#5779 - flintlib/flint#1653 - flintlib/flint#1655 URL: sagemath#36449 Reported by: Vincent Delecroix Reviewer(s): Marc Mezzarobba, Matthias Köppe, Vincent Delecroix

make casts explicit

968e5ca

videlec mentioned this pull request Oct 12, 2023

Autogenerate flint headers sagemath/sage#36449

Merged

5 tasks

albinahlback reviewed Oct 12, 2023

View reviewed changes

fredrik-johansson merged commit e1197f9 into flintlib:trunk Oct 12, 2023
13 checks passed

fingolfin added the workshop 2023 label Oct 13, 2023

videlec deleted the no-implicit-cast branch October 14, 2023 17:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make 3 casts explicit #1523

make 3 casts explicit #1523

videlec commented Oct 12, 2023 •

edited

Loading

albinahlback Oct 12, 2023

videlec Oct 12, 2023

make 3 casts explicit #1523

make 3 casts explicit #1523

Conversation

videlec commented Oct 12, 2023 • edited Loading

albinahlback Oct 12, 2023

Choose a reason for hiding this comment

videlec Oct 12, 2023

Choose a reason for hiding this comment

videlec commented Oct 12, 2023 •

edited

Loading