-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More fixes in rst documentation #1536
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Do you want me to merge these doc fixes for 3.0.0-final? |
As far as sage is concerned it does not matter much. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 24, 2023
We - write down a script to auto-generate flint header files (currently at https://github.com/videlec/flint-header-sage-autogen) - replace most of the files in `src/sage/libs/flint` by auto-generated files. Doing so, the custom sage code in `src/sage/libs/flint` is always contained in files suffixed by `_sage.pxd`/`_sage.pyx`. - deprecate the files in `src/sage/libs/arb/` ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies sagemath#35848 #### Upstream issues and patches - flintlib/flint#1523 - flintlib/flint#1529 - flintlib/flint#1532 - flintlib/flint#1535 - flintlib/flint#1536 - cython/cython#5779 - flintlib/flint#1653 - flintlib/flint#1655 URL: sagemath#36449 Reported by: Vincent Delecroix Reviewer(s): Marc Mezzarobba, Matthias Köppe, Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 25, 2023
We - write down a script to auto-generate flint header files (currently at https://github.com/videlec/flint-header-sage-autogen) - replace most of the files in `src/sage/libs/flint` by auto-generated files. Doing so, the custom sage code in `src/sage/libs/flint` is always contained in files suffixed by `_sage.pxd`/`_sage.pyx`. - deprecate the files in `src/sage/libs/arb/` ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies sagemath#35848 #### Upstream issues and patches - flintlib/flint#1523 - flintlib/flint#1529 - flintlib/flint#1532 - flintlib/flint#1535 - flintlib/flint#1536 - cython/cython#5779 - flintlib/flint#1653 - flintlib/flint#1655 URL: sagemath#36449 Reported by: Vincent Delecroix Reviewer(s): Marc Mezzarobba, Matthias Köppe, Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 27, 2023
We - write down a script to auto-generate flint header files (currently at https://github.com/videlec/flint-header-sage-autogen) - replace most of the files in `src/sage/libs/flint` by auto-generated files. Doing so, the custom sage code in `src/sage/libs/flint` is always contained in files suffixed by `_sage.pxd`/`_sage.pyx`. - deprecate the files in `src/sage/libs/arb/` ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies sagemath#35848 #### Upstream issues and patches - flintlib/flint#1523 - flintlib/flint#1529 - flintlib/flint#1532 - flintlib/flint#1535 - flintlib/flint#1536 - cython/cython#5779 - flintlib/flint#1653 - flintlib/flint#1655 URL: sagemath#36449 Reported by: Vincent Delecroix Reviewer(s): Marc Mezzarobba, Matthias Köppe, Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 2, 2024
We - write down a script to auto-generate flint header files (currently at https://github.com/videlec/flint-header-sage-autogen) - replace most of the files in `src/sage/libs/flint` by auto-generated files. Doing so, the custom sage code in `src/sage/libs/flint` is always contained in files suffixed by `_sage.pxd`/`_sage.pyx`. - deprecate the files in `src/sage/libs/arb/` ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies sagemath#35848 #### Upstream issues and patches - flintlib/flint#1523 - flintlib/flint#1529 - flintlib/flint#1532 - flintlib/flint#1535 - flintlib/flint#1536 - cython/cython#5779 - flintlib/flint#1653 - flintlib/flint#1655 URL: sagemath#36449 Reported by: Vincent Delecroix Reviewer(s): Marc Mezzarobba, Matthias Köppe, Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 5, 2024
We - write down a script to auto-generate flint header files (currently at https://github.com/videlec/flint-header-sage-autogen) - replace most of the files in `src/sage/libs/flint` by auto-generated files. Doing so, the custom sage code in `src/sage/libs/flint` is always contained in files suffixed by `_sage.pxd`/`_sage.pyx`. - deprecate the files in `src/sage/libs/arb/` ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies sagemath#35848 #### Upstream issues and patches - flintlib/flint#1523 - flintlib/flint#1529 - flintlib/flint#1532 - flintlib/flint#1535 - flintlib/flint#1536 - cython/cython#5779 - flintlib/flint#1653 - flintlib/flint#1655 URL: sagemath#36449 Reported by: Vincent Delecroix Reviewer(s): Marc Mezzarobba, Matthias Köppe, Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 13, 2024
We - write down a script to auto-generate flint header files (currently at https://github.com/videlec/flint-header-sage-autogen) - replace most of the files in `src/sage/libs/flint` by auto-generated files. Doing so, the custom sage code in `src/sage/libs/flint` is always contained in files suffixed by `_sage.pxd`/`_sage.pyx`. - deprecate the files in `src/sage/libs/arb/` ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies sagemath#35848 #### Upstream issues and patches - flintlib/flint#1523 - flintlib/flint#1529 - flintlib/flint#1532 - flintlib/flint#1535 - flintlib/flint#1536 - cython/cython#5779 - flintlib/flint#1653 - flintlib/flint#1655 URL: sagemath#36449 Reported by: Vincent Delecroix Reviewer(s): Marc Mezzarobba, Matthias Köppe, Vincent Delecroix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #1532
Fixes #1535
With that patch, I was able to auto-generate all pxd files automatically for SageMath.