Skip to content

Commit

Permalink
Auto merge of rust-lang#10115 - rdrpenguin04:master, r=flip1995
Browse files Browse the repository at this point in the history
Move `mutex_atomic` to `restriction`

By rust-lang#4295, the general consensus seems to be that `mutex_atomic` is not a useful lint in most cases. If anything, it could be useful as a restriction on code that for whatever reason can't use atomics. Keeping it in `clippy::nursery` is harmful to people attempting to use clippy for soundness.

---

changelog: Moved [`mutex_atomic`] to `restriction`
[rust-lang#10115](rust-lang/rust-clippy#10115)
<!-- chnagelog_checked -->
  • Loading branch information
bors committed Dec 30, 2022
2 parents 4f3ab69 + 0298095 commit 6ccd4eb
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions clippy_lints/src/mutex_atomic.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//! Checks for uses of mutex where an atomic value could be used
//!
//! This lint is **warn** by default
//! This lint is **allow** by default

use clippy_utils::diagnostics::span_lint;
use clippy_utils::ty::is_type_diagnostic_item;
Expand All @@ -20,6 +20,10 @@ declare_clippy_lint! {
/// `std::sync::atomic::AtomicBool` and `std::sync::atomic::AtomicPtr` are leaner and
/// faster.
///
/// On the other hand, `Mutex`es are, in general, easier to
/// verify correctness. An atomic does not behave the same as
/// an equivalent mutex. See [this issue](https://github.com/rust-lang/rust-clippy/issues/4295)'s commentary for more details.
///
/// ### Known problems
/// This lint cannot detect if the mutex is actually used
/// for waiting before a critical section.
Expand All @@ -39,8 +43,8 @@ declare_clippy_lint! {
/// ```
#[clippy::version = "pre 1.29.0"]
pub MUTEX_ATOMIC,
nursery,
"using a mutex where an atomic value could be used instead"
restriction,
"using a mutex where an atomic value could be used instead."
}

declare_clippy_lint! {
Expand Down

0 comments on commit 6ccd4eb

Please sign in to comment.