-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor makeNodeJsLock
#1212
Comments
rohaquinlop
added a commit
to rohaquinlop/makes
that referenced
this issue
Dec 13, 2023
- `makeNodeJsLock` now receives the directory that contains the `package.json` file instead of the `package.json` file itself. - The `package-lock.json` file will be generated in the same directory that contains the `package.json` file. - `makeNodeJsLock` now only receives two parameters: `node_js_version` and `package_json_dir`. - Removed `package_lock` parameter from `makeNodeJsLock`. - Updated `makeNodeJsLock` documentation. Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop
added a commit
to rohaquinlop/makes
that referenced
this issue
Dec 13, 2023
- `makeNodeJsLock` now receives the directory that contains the `package.json` file instead of the `package.json` file itself. - The `package-lock.json` file will be generated in the same directory that contains the `package.json` file. - `makeNodeJsLock` now only receives two parameters: `node_js_version` and `package_json_dir`. - Removed `package_lock` parameter from `makeNodeJsLock`. - Updated `makeNodeJsLock` documentation. Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop
added a commit
to rohaquinlop/makes
that referenced
this issue
Dec 14, 2023
- `makeNodeJsLock` now receives the directory that contains the `package.json` file instead of the `package.json` file itself. - The `package-lock.json` file will be generated in the same directory that contains the `package.json` file. - `makeNodeJsLock` now only receives two parameters: `node_js_version` and `package_json_dir`. - Removed `package_lock` parameter from `makeNodeJsLock`. - Updated `makeNodeJsLock` documentation. Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
dsalaza4
added a commit
that referenced
this issue
Dec 14, 2023
feat(build): #1212 upgrade makenodejslock parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Refactor
makeNodeJsLock
to only receive thenode_js_version
and the path that contains thepackage.json
file, no other parameters will be necessaries to generate thepackage-lock.json
file correctly. The same path that containspackage.json
will always contain thepackage-lock.json
file.makeNodeJsLock
Originally posted by @rohaquinlop in #1208 (comment)
The text was updated successfully, but these errors were encountered: