feat(build): #1212 upgrade makenodejslock parameters #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohaquinlop
force-pushed
the
issue-1212
branch
from
c2aed9a
to
af3f4b2
Compare
dsalaza4
reviewed
Dec 14, 2023
- `makeNodeJsLock` now receives the directory that contains the `package.json` file instead of the `package.json` file itself. - The `package-lock.json` file will be generated in the same directory that contains the `package.json` file. - `makeNodeJsLock` now only receives two parameters: `node_js_version` and `package_json_dir`. - Removed `package_lock` parameter from `makeNodeJsLock`. - Updated `makeNodeJsLock` documentation. Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop
force-pushed
the
issue-1212
branch
from
af3f4b2
to
550f8dd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeNodeJsLocknow receives the directory that contains thepackage.jsonfile instead of thepackage.jsonfile itself.package-lock.jsonfile will be generated in the same directory that contains thepackage.jsonfile.makeNodeJsLocknow only receives two parameters:node_js_versionandpackage_json_dir.package_lockparameter frommakeNodeJsLock.makeNodeJsLockdocumentation.