Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ewk_webview_flutter] Introduce ewk_webview_flutter_tizen #400

Closed
wants to merge 5 commits into from
Closed

[ewk_webview_flutter] Introduce ewk_webview_flutter_tizen #400

wants to merge 5 commits into from

Conversation

bwikbs
Copy link
Member

@bwikbs bwikbs commented Jun 9, 2022

  • This is almost same as the webview_flutter_tizen except for backend web engine.

Signed-off-by: MuHong Byun mh.byun@samsung.com

@bwikbs bwikbs force-pushed the ewk_webview_flutter branch 3 times, most recently from 3202683 to 6daa055 Compare June 9, 2022 06:31
@JRazek JRazek mentioned this pull request Jun 14, 2022
Open
10 tasks
@haesik
Copy link
Member

haesik commented Jun 24, 2022

Can you tell me which source code is based on?
I mean, Where did the ewk header files come from?

@bwikbs
Copy link
Member Author

bwikbs commented Jun 27, 2022

@haesik
These headers are the most up-to-date code at the moment of work.
Currently, this PR is only for checking if ewk is available.
We need a more discussion regarding ewk version. Because there is a problem like key event handling still remaining.

@bwikbs bwikbs force-pushed the ewk_webview_flutter branch 2 times, most recently from b43b8fb to 6824991 Compare June 28, 2022 04:29
@bwikbs
[ewk_webview_flutter] Introduce ewk_webview_flutter_tizen
50ac06e 
* This is almost same as the webview_flutter_tizen except for backend web engine.

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
bbrto21
bbrto21 reviewed Aug 11, 2022
View reviewed changes
packages/ewk_webview_flutter/tizen/src/webview.cc
eina_list_free(pointList);
}

bool WebView::SendKey(const char* key, const char* string, const char* compose,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a report about crash with key input. so I tried to fix it. @bwikbs could you review my fix?

@bbrto21
Copy link
Contributor

bbrto21 commented Aug 11, 2022 •
edited
Loading

I got a requirement to show software keyboard on ewk webview.

This patch to allow showing software keyboard on ewk webview.

Note: FlutterDesktopPluginRegistrarGetNativeWindow is under refactoring at here
cc. @haesik, @Swanseo0

@haesik
Copy link
Member

haesik commented Aug 11, 2022

@bwikbs Can you please update the ewk webview using the [patch] (bbrto21@2fa5705) immediately.

@bwikbs
Copy link
Member Author

bwikbs commented Aug 11, 2022

I got a requirement to show software keyboard on ewk webview.

This patch to allow showing software keyboard on ewk webview.

Note: FlutterDesktopPluginRegistrarGetNativeWindow is under refactoring at here cc. @haesik, @Swanseo0

Thank you!
BTW Can you give me a PR? Then I think it would be better to apply!

@bwikbs
Copy link
Member Author

bwikbs commented Aug 11, 2022

@bwikbs Can you please update the ewk webview using the [patch] (bbrto21@2fa5705) immediately.

Got it!

@bbrto21
Copy link
Contributor

bbrto21 commented Aug 11, 2022

I just opened 2 PR on @bwikbs repo.

@bbrto21 @bwikbs
Fix a crash that occurs with key input
efc492f 
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
@bbrto21 @bwikbs
Enable ime panel on ewk webview
fd21a1e 
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
@bbrto21 bbrto21 mentioned this pull request Aug 11, 2022
Merged
@Swanseo0 Swanseo0 mentioned this pull request Aug 16, 2022
Merged
@Swanseo0
Copy link
Contributor

I opened PR on @bwikbs repo for the change of FlutterDesktopPluginRegistrarGetNativeWindow.

Swanseo0 and others added 2 commits August 19, 2022 10:31
@Swanseo0 @bwikbs
Apply the change of flutter-tizen/engine
5df672c 
Signed-off-by: swan.seo <swan.seo@samsung.com>
@bwikbs
Fix bug related to javascript channel
a9ea8de 
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@bbrto21 bbrto21 mentioned this pull request Nov 1, 2022
Closed
@bbrto21 bbrto21 mentioned this pull request Nov 9, 2022
Closed
@bwikbs
Copy link
Member Author

bwikbs commented Nov 16, 2022

Continued in #479

@bwikbs bwikbs closed this Nov 16, 2022
@bbrto21 bbrto21 mentioned this pull request Nov 17, 2022
Merged
bbrto21 added a commit that referenced this pull request Nov 17, 2022
@bbrto21
[webview_flutter] Rework based on EWK (#482)
126eb21 
* This PR based on #400.
* It provides a much more reliable user experience about web browsing than using LWE.
* But EWK's offscreen rendering only works well on TV devices, so other devices and emulators are not supported.

Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrto21 bbrto21 bbrto21 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bwikbs @haesik @bbrto21 @Swanseo0