Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview_flutter] Rework based on EWK #479

Closed
wants to merge 8 commits into from

Conversation

bbrto21
Copy link
Contributor

@bbrto21 bbrto21 commented Nov 9, 2022

@bbrto21
Copy link
Contributor Author

bbrto21 commented Nov 9, 2022

depend on flutter-tizen/flutter-tizen#460.

@bbrto21
Copy link
Contributor Author

bbrto21 commented Nov 9, 2022

Resolve #399 and related discussion

Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
@bbrto21 bbrto21 marked this pull request as ready for review November 15, 2022 05:57
@@ -1,3 +1,7 @@
## 0.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a big deal.. but how do you start a new version?

Copy link
Contributor Author

@bbrto21 bbrto21 Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'm considering giving webview_flutter_lwe a new version instead. because webview_flutter_lwe will be newly published on pub.dev. What do you think about this?

Copy link
Member

@bwikbs bwikbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.md Outdated Show resolved Hide resolved
packages/webview_flutter/CHANGELOG.md Outdated Show resolved Hide resolved
packages/webview_flutter/README.md Outdated Show resolved Hide resolved
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
bbrto21 added a commit that referenced this pull request Nov 17, 2022
* Change the name for coexistence with EWK-based webview plugin.
* webview_flutter_tizen will change based on EWK in #479 

Signed-off-by: Boram Bae <boram21.bae@samsung.com>
@bbrto21 bbrto21 closed this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[webview_flutter] Introduce webview_flutter base on chromium engine(ewk)
3 participants