Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tooling] mark infra steps as infra steps in yaml files #4473

Merged
merged 5 commits into from
Jul 19, 2023
Merged

[tooling] mark infra steps as infra steps in yaml files #4473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69f16f0
Add infra notation to infra tasks in packages repo
reidbaker Jul 14, 2023
58d69c2
Update ios_platform_tests.yaml to mark simulator removal as infa step
reidbaker Jul 17, 2023
a2a11e3
Update macos_custom_package_tests.yaml to mark simulator removal as i…
reidbaker Jul 17, 2023
3645835
Merge branch 'main' into i120119-mark-infra-plugins
reidbaker Jul 17, 2023
a9f97ac
Merge branch 'main' into i120119-mark-infra-plugins
reidbaker Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .ci/targets/analyze.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: analyze repo tools
script: .ci/scripts/analyze_repo_tools.sh
- name: analyze
Expand Down
1 change: 1 addition & 0 deletions .ci/targets/analyze_legacy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
# Does a sanity check that packages at least pass analysis on the N-1 and N-2
# versions of Flutter stable if the package claims to support that version.
# This is to minimize accidentally making changes that break old versions
Expand Down
2 changes: 2 additions & 0 deletions .ci/targets/android_build_all_packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: create all_packages app
script: .ci/scripts/create_all_packages_app.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: build all_packages for Android debug
script: .ci/scripts/build_all_packages_app.sh
args: ["apk", "debug"]
Expand Down
1 change: 1 addition & 0 deletions .ci/targets/dart_unit_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: Dart unit tests
script: script/tool_runner.sh
args: ["dart-test", "--exclude=script/configs/dart_unit_tests_exceptions.yaml", "--platform=vm"]
Expand Down
2 changes: 2 additions & 0 deletions .ci/targets/ios_build_all_packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: create all_packages app
script: .ci/scripts/create_all_packages_app.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: build all_packages for iOS debug
script: .ci/scripts/build_all_packages_app.sh
args: ["ios", "debug", "--no-codesign"]
Expand Down
3 changes: 3 additions & 0 deletions .ci/targets/ios_platform_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: create simulator
script: .ci/scripts/create_simulator.sh
infra_step: true # Note infra steps failing prevents "always" from running.
reidbaker marked this conversation as resolved.
Show resolved Hide resolved
- name: build examples
script: script/tool_runner.sh
args: ["build-examples", "--ios"]
Expand All @@ -25,3 +27,4 @@ tasks:
- name: remove simulator
script: .ci/scripts/remove_simulator.sh
always: true
infra_step: true
2 changes: 2 additions & 0 deletions .ci/targets/linux_build_all_packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: create all_packages app
script: .ci/scripts/create_all_packages_app.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: build all_packages for Linux debug
script: .ci/scripts/build_all_packages_app.sh
args: ["linux", "debug"]
Expand Down
1 change: 1 addition & 0 deletions .ci/targets/linux_custom_package_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: custom tests
script: script/tool_runner.sh
args: ["custom-test"]
2 changes: 2 additions & 0 deletions .ci/targets/macos_build_all_packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: create all_packages app
script: .ci/scripts/create_all_packages_app.sh
infra_step: true # Note infra steps failing prevents "always" from running.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this step (same as in other yaml files) belong to infra?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes assuming you are asking about if this step is infrastructure around getting a test to start running. This pr is not trying to transfer any additional responsibility to the infra-team. What is important here is in our tooling if prepare_tool or create all_packages app fails. It is not a test failure but an infra failure. Also it is likely to happen to every test that uses the same script at the same time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to see in practice; this could also potentially fail in the roller if the flutter create output changed, which wouldn't really be infra.

I would lean slightly toward not marking it, but we can always adjust later if it's an issue.

- name: build all_packages for macOS debug
script: .ci/scripts/build_all_packages_app.sh
args: ["macos", "debug"]
Expand Down
1 change: 1 addition & 0 deletions .ci/targets/macos_check_podspecs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: validate iOS and macOS podspecs
script: script/tool_runner.sh
args: ["podspec-check"]
3 changes: 3 additions & 0 deletions .ci/targets/macos_custom_package_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: create simulator
script: .ci/scripts/create_simulator.sh
infra_step: true # Note infra steps failing prevents "always" from running.
reidbaker marked this conversation as resolved.
Show resolved Hide resolved
- name: custom package tests
script: .ci/scripts/custom_package_tests.sh
- name: remove simulator
script: .ci/scripts/remove_simulator.sh
always: true
infra_step: true
1 change: 1 addition & 0 deletions .ci/targets/macos_platform_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: build examples
script: script/tool_runner.sh
args: ["build-examples", "--macos"]
Expand Down
1 change: 1 addition & 0 deletions .ci/targets/repo_checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: format
script: script/tool_runner.sh
args: ["format", "--fail-on-change"]
Expand Down
1 change: 1 addition & 0 deletions .ci/targets/repo_tools_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: tool unit tests
script: .ci/scripts/plugin_tools_tests.sh
2 changes: 2 additions & 0 deletions .ci/targets/web_build_all_packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: create all_packages app
script: .ci/scripts/create_all_packages_app.sh
infra_step: true # Note infra steps failing prevents "always" from running.
# No debug version, unlike the other platforms, since web does not support
# debug builds.
- name: build all_packages app for Web release
Expand Down
1 change: 1 addition & 0 deletions .ci/targets/web_dart_unit_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: Dart unit tests - web
script: script/tool_runner.sh
args: ["dart-test", "--exclude=script/configs/dart_unit_tests_exceptions.yaml", "--platform=chrome"]
1 change: 1 addition & 0 deletions .ci/targets/web_platform_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: build examples
script: script/tool_runner.sh
args: ["build-examples", "--web"]
Expand Down
2 changes: 2 additions & 0 deletions .ci/targets/windows_build_all_packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: create all_packages app
script: .ci/scripts/create_all_packages_app.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: build all_packages app for Windows debug
script: .ci/scripts/build_all_packages_app.sh
args: ["windows", "debug"]
Expand Down
1 change: 1 addition & 0 deletions .ci/targets/windows_build_and_platform_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: build examples (Win32)
script: .ci/scripts/build_examples_win32.sh
- name: native unit tests (Win32)
Expand Down
1 change: 1 addition & 0 deletions .ci/targets/windows_custom_package_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: custom package tests
script: .ci/scripts/custom_package_tests.sh
1 change: 1 addition & 0 deletions .ci/targets/windows_dart_unit_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: dart unit tests
script: .ci/scripts/dart_unit_tests_win32.sh