Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tooling] mark infra steps as infra steps in yaml files #4473

Merged
merged 5 commits into from
Jul 19, 2023
Merged

[tooling] mark infra steps as infra steps in yaml files #4473

merged 5 commits into from
Jul 19, 2023

Conversation

reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Jul 14, 2023 •
edited
Loading

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker reidbaker requested review from keyonghan and stuartmorgan and removed request for keyonghan July 14, 2023 17:51
@reidbaker reidbaker changed the title i120119 mark infra plugins [tooling] mark infra steps as infra steps in yaml files Jul 14, 2023
keyonghan
keyonghan reviewed Jul 14, 2023
View reviewed changes
.ci/targets/macos_build_all_packages.yaml
- name: create all_packages app
script: .ci/scripts/create_all_packages_app.sh
infra_step: true # Note infra steps failing prevents "always" from running.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this step (same as in other yaml files) belong to infra?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes assuming you are asking about if this step is infrastructure around getting a test to start running. This pr is not trying to transfer any additional responsibility to the infra-team. What is important here is in our tooling if prepare_tool or create all_packages app fails. It is not a test failure but an infra failure. Also it is likely to happen to every test that uses the same script at the same time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to see in practice; this could also potentially fail in the roller if the flutter create output changed, which wouldn't really be infra.

I would lean slightly toward not marking it, but we can always adjust later if it's an issue.

keyonghan
keyonghan approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stuartmorgan
stuartmorgan approved these changes Jul 14, 2023
View reviewed changes
.ci/targets/ios_platform_tests.yaml Show resolved Hide resolved
.ci/targets/macos_build_all_packages.yaml
- name: create all_packages app
script: .ci/scripts/create_all_packages_app.sh
infra_step: true # Note infra steps failing prevents "always" from running.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to see in practice; this could also potentially fail in the roller if the flutter create output changed, which wouldn't really be infra.

I would lean slightly toward not marking it, but we can always adjust later if it's an issue.

.ci/targets/macos_custom_package_tests.yaml Show resolved Hide resolved
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 18, 2023

auto label is removed for flutter/packages, pr: 4473, due to - The status or check suite android-platform_tests CHANNEL:master PACKAGE_SHARDING:--shardIndex 1 --shardCount 6 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 19, 2023
@auto-submit auto-submit bot merged commit 209db21 into flutter:main Jul 19, 2023
72 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2023
@engine-flutter-autoroll
209db21 [tooling] mark infra steps as infra steps in yaml files (flut…
3cdaecb 
…ter/packages#4473)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 19, 2023
@engine-flutter-autoroll
Roll Packages from 3e8b813 to 209db21 (8 revisions) (#130894)
5661988 
flutter/packages@3e8b813...209db21

2023-07-19 reidbaker@google.com [tooling] mark infra steps as infra steps in yaml files (flutter/packages#4473)
2023-07-19 engine-flutter-autoroll@skia.org Manual roll Flutter from f842ed9 to 6f09064 (11 revisions) (flutter/packages#4518)
2023-07-19 stuartmorgan@google.com [ci] Enable new sharding (flutter/packages#4515)
2023-07-19 stuartmorgan@google.com [flutter_markdown] Change the way tests get screen size (flutter/packages#4514)
2023-07-18 stuartmorgan@google.com [ci] Roll Flutter to f842ed9 (flutter/packages#4513)
2023-07-18 stuartmorgan@google.com [image_picker] Update Android example (flutter/packages#4504)
2023-07-18 43054281+camsim99@users.noreply.github.com [camerax] Fixes relistening to `onStreamedFrameAvailable`'s stream behavior (flutter/packages#4511)
2023-07-18 43054281+camsim99@users.noreply.github.com [various] Deletes deprecated splash screen meta-data element (flutter/packages#4501)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@engine-flutter-autoroll @LouiseHsu
Roll Packages from 3e8b813 to 209db21 (8 revisions) (flutter#130894)
51d0303 
flutter/packages@3e8b813...209db21

2023-07-19 reidbaker@google.com [tooling] mark infra steps as infra steps in yaml files (flutter/packages#4473)
2023-07-19 engine-flutter-autoroll@skia.org Manual roll Flutter from f842ed9 to 6f09064 (11 revisions) (flutter/packages#4518)
2023-07-19 stuartmorgan@google.com [ci] Enable new sharding (flutter/packages#4515)
2023-07-19 stuartmorgan@google.com [flutter_markdown] Change the way tests get screen size (flutter/packages#4514)
2023-07-18 stuartmorgan@google.com [ci] Roll Flutter to f842ed9 (flutter/packages#4513)
2023-07-18 stuartmorgan@google.com [image_picker] Update Android example (flutter/packages#4504)
2023-07-18 43054281+camsim99@users.noreply.github.com [camerax] Fixes relistening to `onStreamedFrameAvailable`'s stream behavior (flutter/packages#4511)
2023-07-18 43054281+camsim99@users.noreply.github.com [various] Deletes deprecated splash screen meta-data element (flutter/packages#4501)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@keyonghan keyonghan keyonghan approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reidbaker @stuartmorgan @keyonghan