[ci] Roll Flutter to f842ed91 #4513

stuartmorgan · 2023-07-18T18:35:19Z

Rolls Flutter master to f842ed9 manually.

The switch to Material 3 by default broke the expectations of the dynamic_layouts package; this updates them to handle the values reported starting with that switch.

stuartmorgan · 2023-07-18T18:37:06Z

@Piinks I bisected to the M3 switch commit, so I'm sure that's the cause. I'm assuming that means these changes are expected, but if that's not the case I'd like to spin that out into an issue for follow-up so that I can get the roller unblocked.

Piinks

This LGTM - thank you for fixing it!

Piinks · 2023-07-18T18:57:37Z

packages/dynamic_layouts/example/test/wrap_example_test.dart

@@ -23,10 +22,21 @@ void main() {
    expect(find.text('Index 3'), findsOneWidget);
    expect(find.text('Index 4'), findsOneWidget);

+    // Material 3 changes the expected layout positioning.
+    final bool usesMaterial3 = (app.theme ?? ThemeData.light()).useMaterial3;


Yes, I double checked. The slight change in offset is expected.

Perfect, thanks for verifying!

auto-submit · 2023-07-18T19:05:20Z

auto label is removed for flutter/packages, pr: 4513, due to - The status or check suite Linux_web web_dart_unit_test_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

stuartmorgan · 2023-07-18T19:06:51Z

Ugh, looks like web has slightly different offsets. I'll adjust accordingly for web...

Piinks · 2023-07-18T19:13:12Z

Oh man. @HansMuller is there meant to be such discrepancies with Material 3 across platforms? I would expect the pixels to be the same when building the same across platforms. It was the same when this was tested in M2. The disparity here is coming from the text, is there a different visual density across platforms for Material 3?

stuartmorgan · 2023-07-18T19:14:37Z

It's exactly half a pixel different, so maybe it's a physical pixel alignment thing?

stuartmorgan · 2023-07-18T19:15:59Z

I pushed a version that does half-pixel adjustment for web. The other option I can see is that I could do within-half-a-pixel checks on all platforms instead.

ditman · 2023-07-18T20:08:21Z

packages/dynamic_layouts/example/test/wrap_example_test.dart

  });
 }
+
+double _getExpectedYOffset(double nonWeb) {
+  return kIsWeb ? nonWeb - 0.5 : nonWeb;


Yikes! Is this a "web is rounding wrong" bug?

Hmmm maybe @yjbanov would know?

I brought this up to the team chat as well!

I vaguely recall we had a special-case for an off-by-one issue in text for Firefox, but not generally. @mdebbar might know more.

stuartmorgan · 2023-07-18T20:46:44Z

I'm going to go ahead and autosubmit this as-is since our roller is many days behind and I want to unblock it; we can definitely iterate on how exactly we handle the web diff (and investigate the framework if that's a concern) after the fact.

ditman · 2023-07-18T21:00:35Z

@stuartmorgan ACK, we'll revisit this adjustment if we end up doing any changes that affect the vertical spacing in the web later.

flutter/packages@3e8b813...209db21 2023-07-19 reidbaker@google.com [tooling] mark infra steps as infra steps in yaml files (flutter/packages#4473) 2023-07-19 engine-flutter-autoroll@skia.org Manual roll Flutter from f842ed9 to 6f09064 (11 revisions) (flutter/packages#4518) 2023-07-19 stuartmorgan@google.com [ci] Enable new sharding (flutter/packages#4515) 2023-07-19 stuartmorgan@google.com [flutter_markdown] Change the way tests get screen size (flutter/packages#4514) 2023-07-18 stuartmorgan@google.com [ci] Roll Flutter to f842ed9 (flutter/packages#4513) 2023-07-18 stuartmorgan@google.com [image_picker] Update Android example (flutter/packages#4504) 2023-07-18 43054281+camsim99@users.noreply.github.com [camerax] Fixes relistening to `onStreamedFrameAvailable`'s stream behavior (flutter/packages#4511) 2023-07-18 43054281+camsim99@users.noreply.github.com [various] Deletes deprecated splash screen meta-data element (flutter/packages#4501) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This refactors a test for the example of a wrapped layout in dynamic_tests. This test had become brittle to small text changes because it would check the precise layout offset of the text. It was patched in these cases in #4513 and #4677 to address tiny text variations across platforms and material 2/3 defaults. This refactor changes the test to check the layout offset of the parent Container of the text, which should not have these subtle variations. Fixes flutter/flutter#132321

stuartmorgan added 2 commits July 18, 2023 14:13

Roll to 3 days ago

be3d176

Make tests handle M3

0c54586

stuartmorgan requested a review from Piinks as a code owner July 18, 2023 18:35

github-actions bot added the p: dynamic_layouts The dynamic_layouts package label Jul 18, 2023

Piinks approved these changes Jul 18, 2023

View reviewed changes

stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2023

Adjust for web

049be7c

stuartmorgan changed the title ~~[ci] Roll Flutter to f842ed916514879fe6898b2a5a4053c63c3308fe~~ [ci] Roll Flutter to f842ed91 Jul 18, 2023

ditman reviewed Jul 18, 2023

View reviewed changes

stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2023

auto-submit bot merged commit 7f07f66 into flutter:main Jul 18, 2023
72 checks passed

stuartmorgan deleted the roll-2023-07-18-first branch July 18, 2023 21:49

engine-flutter-autoroll mentioned this pull request Jul 19, 2023

Roll Packages from 3e8b8130cda3 to 209db219ad73 (8 revisions) flutter/flutter#130894

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2023

7f07f66 [ci] Roll Flutter to f842ed9 (flutter/packages#4513)

9c3f44d

reidbaker mentioned this pull request Jul 26, 2023

[Tooling] Add google owned cache for dependencies as an option in ci #4567

Merged

11 tasks

reidbaker mentioned this pull request Aug 4, 2023

[All] Expand artifact hub to all plugins #4645

Merged

11 tasks

Piinks mentioned this pull request Aug 11, 2023

[dynamic_layouts] Refactor flaky test #4681

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ci] Roll Flutter to f842ed91 #4513

[ci] Roll Flutter to f842ed91 #4513

stuartmorgan commented Jul 18, 2023

stuartmorgan commented Jul 18, 2023

Piinks left a comment

Piinks Jul 18, 2023

stuartmorgan Jul 18, 2023

auto-submit bot commented Jul 18, 2023

stuartmorgan commented Jul 18, 2023

Piinks commented Jul 18, 2023

stuartmorgan commented Jul 18, 2023

stuartmorgan commented Jul 18, 2023 •

edited

Loading

ditman Jul 18, 2023

Piinks Jul 18, 2023

ditman Jul 18, 2023

yjbanov Jul 18, 2023

stuartmorgan commented Jul 18, 2023

ditman commented Jul 18, 2023

[ci] Roll Flutter to f842ed91 #4513

[ci] Roll Flutter to f842ed91 #4513

Conversation

stuartmorgan commented Jul 18, 2023

stuartmorgan commented Jul 18, 2023

Piinks left a comment

Choose a reason for hiding this comment

Piinks Jul 18, 2023

Choose a reason for hiding this comment

stuartmorgan Jul 18, 2023

Choose a reason for hiding this comment

auto-submit bot commented Jul 18, 2023

stuartmorgan commented Jul 18, 2023

Piinks commented Jul 18, 2023

stuartmorgan commented Jul 18, 2023

stuartmorgan commented Jul 18, 2023 • edited Loading

ditman Jul 18, 2023

Choose a reason for hiding this comment

Piinks Jul 18, 2023

Choose a reason for hiding this comment

ditman Jul 18, 2023

Choose a reason for hiding this comment

yjbanov Jul 18, 2023

Choose a reason for hiding this comment

stuartmorgan commented Jul 18, 2023

ditman commented Jul 18, 2023

stuartmorgan commented Jul 18, 2023 •

edited

Loading