Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[local_auth] fix: isDeviceSupported on ios #5125

Merged
merged 7 commits into from
Feb 7, 2024
Merged

[local_auth] fix: isDeviceSupported on ios #5125

merged 7 commits into from
Feb 7, 2024

Conversation

techno-disaster
Copy link
Contributor

@techno-disaster techno-disaster commented Oct 12, 2023 •
edited
Loading

Fixes: flutter/flutter#116179

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@techno-disaster techno-disaster changed the title fix: isDeviceSupported on ios [local_auth] fix: isDeviceSupported on ios Oct 12, 2023
stuartmorgan
stuartmorgan requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! As discussed in Discord, this will need a native unit test.

packages/local_auth/local_auth/CHANGELOG.md Outdated Show resolved Hide resolved
packages/local_auth/local_auth_ios/CHANGELOG.md Outdated Show resolved Hide resolved
packages/local_auth/local_auth_ios/ios/Classes/FLTLocalAuthPlugin.m Outdated Show resolved Hide resolved
packages/local_auth/local_auth_ios/ios/Classes/FLTLocalAuthPlugin.m Outdated Show resolved Hide resolved
packages/local_auth/local_auth_ios/ios/Classes/FLTLocalAuthPlugin.m Outdated Show resolved Hide resolved
@goderbauer
Copy link
Member

@techno-disaster Hello from our triage meeting. Do you still have plans to address the feedback given above?

@techno-disaster
Copy link
Contributor Author

@techno-disaster Hello from our triage meeting. Do you still have plans to address the feedback given above?

Yes, plan to get to it as soon as I find some free time, but please feel free to takeover the PR if required.

@jmagman jmagman self-requested a review January 31, 2024 21:55
stuartmorgan
stuartmorgan approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed changes that addressed my comments; @jmagman do you want to do the final review?

jmagman
jmagman approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 7, 2024
@auto-submit auto-submit bot merged commit 29d8cc0 into flutter:main Feb 7, 2024
78 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 8, 2024
@engine-flutter-autoroll
29d8cc0 [local_auth] fix: isDeviceSupported on ios (flutter/packages#…
5102f21 
…5125)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 8, 2024
@engine-flutter-autoroll
Roll Packages from e4ea6bf to 29d8cc0 (5 revisions) (#143161)
eb5d0a4 
flutter/packages@e4ea6bf...29d8cc0

2024-02-07 td@technodisaster.com [local_auth] fix: isDeviceSupported on ios (flutter/packages#5125)
2024-02-07 jason-simmons@users.noreply.github.com [image_picker] Suppress analyzer warning about deprecation of UnmodifiableUint8ListView (flutter/packages#6076)
2024-02-07 58767497+GiftShower@users.noreply.github.com Add transitionDuration parameter (flutter/packages#5854)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter from e6ba809 to 8431cae (23 revisions) (flutter/packages#6075)
2024-02-07 ltv.luongthevinh@gmail.com [webview_flutter_android][webview_flutter_wkwebview] Adds support for `setOnScrollPositionChange` for webview_flutter platform implementations (flutter/packages#5664)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@techno-disaster @arc-yong
[local_auth] fix: isDeviceSupported on ios (flutter#5125)
d0c626a 
Fixes: flutter/flutter#116179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: local_auth platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[local_auth][Ios] isDeviceSupported returns always true
4 participants
@techno-disaster @goderbauer @stuartmorgan @jmagman