-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[image_picker] Suppress analyzer warning about deprecation of UnmodifiableUint8ListView #6076
Conversation
@@ -27,6 +27,8 @@ class PickedFile extends PickedFileBase { | |||
|
|||
Future<Uint8List> get _bytes async { | |||
if (_initBytes != null) { | |||
// See https://github.com/flutter/flutter/issues/143110 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a TODO to do the migration, with a link to an issue that stays open and describes the migration needed and information about what release the replacement is available in. The goal isn't to leave ignore
s indefinitely, but to clearly track the need to remove them and the timeline for doing so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed flutter/flutter#143113 and updated the PR
PTAL
…iableUint8ListView See flutter/flutter#143113
8464b3a
to
b8fe20c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this doesn't need to be published to pub, should be good to land as is.
… UnmodifiableUint8ListView (flutter/packages#6076)
flutter/packages@e4ea6bf...29d8cc0 2024-02-07 td@technodisaster.com [local_auth] fix: isDeviceSupported on ios (flutter/packages#5125) 2024-02-07 jason-simmons@users.noreply.github.com [image_picker] Suppress analyzer warning about deprecation of UnmodifiableUint8ListView (flutter/packages#6076) 2024-02-07 58767497+GiftShower@users.noreply.github.com Add transitionDuration parameter (flutter/packages#5854) 2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter from e6ba809 to 8431cae (23 revisions) (flutter/packages#6075) 2024-02-07 ltv.luongthevinh@gmail.com [webview_flutter_android][webview_flutter_wkwebview] Adds support for `setOnScrollPositionChange` for webview_flutter platform implementations (flutter/packages#5664) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…iableUint8ListView (flutter#6076) See flutter/flutter#143110
See flutter/flutter#143110