Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SchedulerBinding.instance is now null-safe #123

Merged
merged 3 commits into from
May 3, 2022
Merged

fix: SchedulerBinding.instance is now null-safe #123

merged 3 commits into from
May 3, 2022
+10 −3

Conversation

mockturtl
Copy link
Contributor

@mockturtl mockturtl commented Apr 21, 2022 •
edited
Loading

Closes #122.

You may prefer to just ignore the warning, for backwards compatibility with flutter <= 2.10.

You could delay merging until flutter 2.13(?) becomes stable, or else publish a prerelease (say v0.7.2-0) that specifies a minimum flutter version in pubspec.yaml:

environment:
  sdk: ">=2.17.0-0 <3.0.0"
  flutter:  ">=2.12.0-4.0.pre"
  # seems to be the first time flutter/flutter@ab89ce285 exists

@mockturtl mockturtl force-pushed the fix-122-schedulerbinding branch 2 times, most recently from 445ffe1 to 03143ce Compare April 21, 2022 03:44
@mockturtl mockturtl force-pushed the fix-122-schedulerbinding branch from d14f7ed to 51a3efd Compare April 21, 2022 03:55
@daadu daadu changed the base branch from master to beta May 3, 2022 05:19
@daadu
Copy link
Member

daadu commented May 3, 2022

@mockturtl Thanks for the contribution, will go with pre-release

@daadu daadu merged commit 385637f into fluttercommunity:beta May 3, 2022
@daadu daadu mentioned this pull request May 3, 2022
Merged
@mockturtl mockturtl deleted the fix-122-schedulerbinding branch May 3, 2022 14:36
@daadu
Copy link
Member

daadu commented May 12, 2022

This change has landed on pub.dev with v0.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flutter beta: SchedulerBinding is now null-safe
2 participants
@mockturtl @daadu