Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SchedulerBinding.instance is now null-safe #124

Merged
merged 3 commits into from
May 3, 2022
Merged

fix: SchedulerBinding.instance is now null-safe #124

merged 3 commits into from
May 3, 2022

Conversation

daadu
Copy link
Member

@daadu daadu commented May 3, 2022

Re-opened from #123

Closes #122.

You may prefer to just ignore the warning, for backwards compatibility with flutter <= 2.10.

You could delay merging until flutter 2.13(?) becomes stable, or else publish a prerelease (say v0.7.2-0) that specifies a minimum flutter version in pubspec.yaml:

environment:
  sdk: ">=2.17.0-0 <3.0.0"
  flutter:  ">=2.12.0-4.0.pre"
  # seems to be the first time flutter/flutter@ab89ce285 exists

@daadu daadu merged commit fffadfa into fluttercommunity:beta May 3, 2022
@mockturtl mockturtl deleted the fix-122-schedulerbinding branch May 3, 2022 14:36
daadu added a commit that referenced this pull request May 12, 2022
@daadu @mockturtl
fix: SchedulerBinding.instance is now null-safe (#124) (#125)
ce6ef36 
* fix: SchedulerBinding.instance is now null-safe (#124)

* flutter: raised min support to v3.0.0

Co-authored-by: mockturtl <mockturtl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daadu @mockturtl