Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add auto-formatting with prettier in make crd command #1740

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kahirokunn
Copy link
Contributor

@kahirokunn kahirokunn commented Dec 12, 2024

Overview

This PR adds automatic code formatting using prettier when generating CRD manifests through the make crd command. This ensures consistent formatting across all generated CRD files.

Changes

  • Added prettier formatting step in the CRD generation process
  • Updated Makefile to include prettier in the make crd command

Purpose

  • Maintains consistent code style in generated CRD files
  • Reduces manual formatting effort
  • Improves readability of generated manifests

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@kahirokunn kahirokunn changed the title Format CRD feat: Add auto-formatting with prettier in make crd command Dec 12, 2024
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.30%. Comparing base (8f83838) to head (fffa471).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1740      +/-   ##
==========================================
+ Coverage   35.08%   39.30%   +4.21%     
==========================================
  Files         283      284       +1     
  Lines       24653    22391    -2262     
==========================================
+ Hits         8650     8801     +151     
+ Misses      15063    12643    -2420     
- Partials      940      947       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants