Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add auto-formatting with prettier in make crd command #1740

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add auto-formatting with prettier in make crd command #1740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fb2b83
build(Makefile): Add prettier format step to crd task
kahirokunn Dec 12, 2024
fffa471
run `make crd`
kahirokunn Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ test-coverage: fmt test-codegen
rm cover.out

crd:
npx prettier -w artifacts/flagger/crd.yaml
cat artifacts/flagger/crd.yaml > charts/flagger/crds/crd.yaml
cat artifacts/flagger/crd.yaml > kustomize/base/flagger/crd.yaml

Expand Down
125 changes: 72 additions & 53 deletions artifacts/flagger/crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,16 @@ spec:
type: object
properties:
apiVersion:
description: 'APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the latest
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
description:
"APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the latest
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources"
type: string
kind:
description: 'Kind is a string value representing the REST resource this
object represents. Servers may infer this from the endpoint the client
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
description:
"Kind is a string value representing the REST resource this
object represents. Servers may infer this from the endpoint the client
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds"
type: string
metadata:
type: object
Expand Down Expand Up @@ -150,7 +152,7 @@ spec:
routeRef:
description: APISIX route selector
type: object
required: [ "apiVersion", "kind", "name" ]
required: ["apiVersion", "kind", "name"]
properties:
apiVersion:
type: string
Expand All @@ -163,7 +165,7 @@ spec:
upstreamRef:
description: Gloo Upstream selector
type: object
required: [ "apiVersion", "kind", "name" ]
required: ["apiVersion", "kind", "name"]
properties:
apiVersion:
type: string
Expand Down Expand Up @@ -524,14 +526,15 @@ spec:
minimum: 1
type: integer
required:
- name
- name
type: object
x-kubernetes-validations:
- message: Must have port for Service reference
rule: '(size(self.group) == 0 && self.kind == ''Service'')
? has(self.port) : true'
- message: Must have port for Service reference
rule:
"(size(self.group) == 0 && self.kind == 'Service')
? has(self.port) : true"
required:
- backendRef
- backendRef
headers:
description: Headers operations
type: object
Expand Down Expand Up @@ -583,7 +586,7 @@ spec:
type: array
items:
required:
- name
- name
type: object
properties:
group:
Expand Down Expand Up @@ -634,7 +637,8 @@ spec:
type: string
type: array
allowOrigin:
description: The list of origins that are allowed to perform
description:
The list of origins that are allowed to perform
CORS requests.
items:
format: string
Expand Down Expand Up @@ -681,15 +685,17 @@ spec:
type: object
properties:
h2UpgradePolicy:
description: Specify if http1.1 connection should
description:
Specify if http1.1 connection should
be upgraded to http2 for the associated destination.
enum:
- DEFAULT
- DO_NOT_UPGRADE
- UPGRADE
type: string
http1MaxPendingRequests:
description: Maximum number of pending HTTP requests
description:
Maximum number of pending HTTP requests
to a destination.
format: int32
type: integer
Expand All @@ -698,11 +704,13 @@ spec:
format: int32
type: integer
idleTimeout:
description: The idle timeout for upstream connection
description:
The idle timeout for upstream connection
pool connections.
type: string
maxRequestsPerConnection:
description: Maximum number of requests per connection
description:
Maximum number of requests per connection
to a backend.
format: int32
type: integer
Expand Down Expand Up @@ -763,31 +771,36 @@ spec:
localityLbSetting:
properties:
distribute:
description: 'Optional: only one of distribute or
failover can be set.'
description:
"Optional: only one of distribute or
failover can be set."
items:
properties:
from:
description: Originating locality, '/' separated,
description:
Originating locality, '/' separated,
e.g.
format: string
type: string
to:
additionalProperties:
type: integer
description: Map of upstream localities to traffic
description:
Map of upstream localities to traffic
distribution weights.
type: object
type: object
type: array
enabled:
description: enable locality load balancing, this
description:
enable locality load balancing, this
is DestinationRule-level and will override mesh
wide settings in entirety.
type: boolean
failover:
description: 'Optional: only failover or distribute
can be set.'
description:
"Optional: only failover or distribute
can be set."
items:
properties:
from:
Expand Down Expand Up @@ -819,14 +832,16 @@ spec:
description: Minimum ejection duration.
type: string
consecutive5xxErrors:
description: Number of 5xx errors before a host is ejected
description:
Number of 5xx errors before a host is ejected
from the connection pool.
type: integer
consecutiveErrors:
format: int32
type: integer
consecutiveGatewayErrors:
description: Number of gateway errors before a host is
description:
Number of gateway errors before a host is
ejected from the connection pool.
format: int32
type: integer
Expand Down Expand Up @@ -994,20 +1009,20 @@ spec:
type: object
additionalProperties:
oneOf:
- not:
anyOf:
- required:
- not:
anyOf:
- required:
- exact
- required:
- prefix
- required:
- regex
- required:
- exact
- required:
- required:
- prefix
- required:
- required:
- regex
- required:
- exact
- required:
- prefix
- required:
- regex
properties:
exact:
type: string
Expand Down Expand Up @@ -1148,7 +1163,7 @@ spec:
sessionAffinity:
description: SessionAffinity represents the session affinity settings for a canary run.
type: object
required: [ "cookieName" ]
required: ["cookieName"]
properties:
cookieName:
description: CookieName is the key that will be used for the session affinity cookie.
Expand Down Expand Up @@ -1212,7 +1227,7 @@ spec:
type: array
items:
type: object
required: [ "type", "status", "reason" ]
required: ["type", "status", "reason"]
properties:
lastTransitionTime:
description: LastTransitionTime of this condition
Expand Down Expand Up @@ -1267,14 +1282,16 @@ spec:
type: object
properties:
apiVersion:
description: 'APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the latest
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
description:
"APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the latest
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources"
type: string
kind:
description: 'Kind is a string value representing the REST resource this
object represents. Servers may infer this from the endpoint the client
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
description:
"Kind is a string value representing the REST resource this
object represents. Servers may infer this from the endpoint the client
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds"
type: string
metadata:
type: object
Expand Down Expand Up @@ -1358,14 +1375,16 @@ spec:
type: object
properties:
apiVersion:
description: 'APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the latest
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
description:
"APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the latest
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources"
type: string
kind:
description: 'Kind is a string value representing the REST resource this
object represents. Servers may infer this from the endpoint the client
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
description:
"Kind is a string value representing the REST resource this
object represents. Servers may infer this from the endpoint the client
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds"
type: string
metadata:
type: object
Expand Down
Loading
Loading