This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix more links #2948
Merged
Fix more links #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hohum... not sure what to do about this: README.md |
dholbach
force-pushed
the
fix-links
branch
3 times, most recently
from
March 31, 2020 14:19
b711f47
to
99605c8
Compare
I never knew that checking links would turn into a minefield like this. What I attempt to do in this PR is
Might need some help here. 😍 |
dholbach
changed the title
Fix more links, add more rigorous link checking
Fix more links
Apr 1, 2020
dholbach
pushed a commit
that referenced
this pull request
Apr 1, 2020
I'll make this PR just about fixing links, so we can merge it ASAP. #2956 is about checking links. |
hiddeco
approved these changes
Apr 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
dholbach
pushed a commit
that referenced
this pull request
Apr 1, 2020
dholbach
pushed a commit
that referenced
this pull request
Apr 1, 2020
- .github/workflows/markdown-link-check-config.json has some patterns we exlude while checking the markdown files in the top-level directories (company websites on README.md and billions of GH issues in CHANGELOG.md in particular) - once gaurav-nelson/github-action-markdown-link-check#26 is merged, we can move back to the official GH Action
dholbach
pushed a commit
that referenced
this pull request
Apr 3, 2020
- .github/workflows/markdown-link-check-config.json has some patterns we exlude while checking the markdown files in the top-level directories (company websites on README.md and billions of GH issues in CHANGELOG.md in particular) - once gaurav-nelson/github-action-markdown-link-check#26 is merged, we can move back to the official GH Action
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up from fluxcd/helm-operator#347 here is the link checking being updated and a bunch of old links fixed too.