Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Fix more links #2948

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Fix more links #2948

merged 1 commit into from
Apr 1, 2020

Conversation

dholbach
Copy link
Member

As a follow-up from fluxcd/helm-operator#347 here is the link checking being updated and a bunch of old links fixed too.

@dholbach dholbach added the docs Issue or PR relates to documentation label Mar 30, 2020
@dholbach
Copy link
Member Author

Hohum... not sure what to do about this:

README.md
ERROR https://chattigo.com
X509: certificate signed by unknown authority
ERROR https://img.shields.io/badge/latest-documentation-informational
(HTTP error 522)
ERROR https://www.blablacar.com/
Forbidden (HTTP error 403)
ERROR https://www.canva.com/
Forbidden (HTTP error 403)
ERROR https://www.underarmour.com
Forbidden (HTTP error 403)

@dholbach dholbach force-pushed the fix-links branch 3 times, most recently from b711f47 to 99605c8 Compare March 31, 2020 14:19
@dholbach
Copy link
Member Author

I never knew that checking links would turn into a minefield like this. What I attempt to do in this PR is

  • use liche (through the GH Action) for the docs we generate using mkdocs (docssite) - this works great.
  • use markdown-link-checker (through GH action) for checking internal/docs and the top-level markdown files (the latter is where we have LOTS OF links that cause us to get all kinds of spurious results)

Might need some help here. 😍

@dholbach dholbach changed the title Fix links Fix more links, add more rigorous link checking Apr 1, 2020
@dholbach dholbach changed the title Fix more links, add more rigorous link checking Fix more links Apr 1, 2020
dholbach pushed a commit that referenced this pull request Apr 1, 2020
@dholbach
Copy link
Member Author

dholbach commented Apr 1, 2020

I'll make this PR just about fixing links, so we can merge it ASAP. #2956 is about checking links.

@dholbach dholbach self-assigned this Apr 1, 2020
@dholbach dholbach added this to the 1.19.0 milestone Apr 1, 2020
@dholbach dholbach requested a review from hiddeco April 1, 2020 09:13
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dholbach dholbach merged commit 6377745 into master Apr 1, 2020
@dholbach dholbach deleted the fix-links branch April 1, 2020 09:24
dholbach pushed a commit that referenced this pull request Apr 1, 2020
dholbach pushed a commit that referenced this pull request Apr 1, 2020
	- .github/workflows/markdown-link-check-config.json has some
	  patterns we exlude while checking the markdown files in the
	  top-level directories (company websites on README.md and
	  billions of GH issues in CHANGELOG.md in particular)
	- once gaurav-nelson/github-action-markdown-link-check#26
	  is merged, we can move back to the official GH Action
dholbach pushed a commit that referenced this pull request Apr 3, 2020
	- .github/workflows/markdown-link-check-config.json has some
	  patterns we exlude while checking the markdown files in the
	  top-level directories (company websites on README.md and
	  billions of GH issues in CHANGELOG.md in particular)
	- once gaurav-nelson/github-action-markdown-link-check#26
	  is merged, we can move back to the official GH Action
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Issue or PR relates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants